fix(ci): resolve nightly Clippy lints - #16092
Merged
Merged
Conversation
mattsse
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr and
stevencartavia
as code owners
August 8, 2026 15:02
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
figtracer
previously approved these changes
Aug 8, 2026
figtracer
enabled auto-merge (squash)
August 8, 2026 15:04
Member
Author
|
@figtracer looks like we still need some changes from #16076 |
Member
|
@mattsse maybe lets push it directly here, i also closed mine |
The async-trait update removes generated double_must_use warnings, but the latest nightly also reports suboptimal floating-point operations and shared match-arm tails. Apply the remaining behavior-preserving Clippy rewrites so the workspace lint job passes.
mattsse
changed the title
figtracer
self-requested a review
August 8, 2026 15:43
figtracer
approved these changes
Aug 8, 2026
stevencartavia
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly Clippy introduced
double_must_usediagnostics inasync-trait-generated code alongsidesuboptimal_flopsandbranches_sharing_codewarnings in Foundry. This updatesasync-traitfrom 0.1.91 to 0.1.92 to resolve the generated warning and applies the behavior-preserving floating-point and shared match-arm-tail rewrites, restoring the workspace Clippy gate without a global lint allowance.This PR was authored with OpenAI Codex, including dependency and CI investigation, implementation, validation, and PR preparation.