Skip to content

fix: use closedByPullRequestsReferences in gh_issue_close (#5) - #6

Merged
four-bytes-robby merged 1 commit into
mainfrom
fix/5-gh-issue-close-json-field
Sep 5, 2026
Merged

fix: use closedByPullRequestsReferences in gh_issue_close (#5)#6
four-bytes-robby merged 1 commit into
mainfrom
fix/5-gh-issue-close-json-field

Conversation

@four-bytes-robby

@four-bytes-robby four-bytes-robby commented Sep 5, 2026

Copy link
Copy Markdown
Member

fixes issue #5gh_issue_close crashed on the removed closedByPullRequestsUrls JSON field; switched to closedByPullRequestsReferences (array of {number, url}).

Closes #5


Summary by cubic

Fixes gh_issue_close crashing on the removed closedByPullRequestsUrls JSON field by switching to closedByPullRequestsReferences, which returns an array of {number, url} objects. The zombie-issue output now shows both the PR number and URL.

Written for commit 1bf4cc5. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved closed-issue detection by using pull request references directly.
    • Issue details now display both the pull request number and URL when identifying issues closed by pull requests.
    • Updated issue data handling to provide more complete and reliable pull request information.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a050bd2a-68df-46c4-a2c1-400f59f990ab

📥 Commits

Reviewing files that changed from the base of the PR and between 80ab0b6 and 1bf4cc5.

📒 Files selected for processing (1)
  • src/tools/gh-issue-close.ts

📝 Walkthrough

Walkthrough

The issue closure tool now requests GitHub’s closedByPullRequestsReferences field, models pull request numbers and URLs, and displays both values during zombie-issue detection.

Changes

Issue closure field update

Layer / File(s) Summary
Update issue view references
src/tools/gh-issue-close.ts
The IssueView interface and gh issue view request use closedByPullRequestsReferences. Zombie detection iterates the reference objects and prints each URL with its pull request number.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/5-gh-issue-close-json-field
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/5-gh-issue-close-json-field

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@four-bytes-robby
four-bytes-robby merged commit 13965fa into main Sep 5, 2026
1 of 3 checks passed
@four-bytes-robby
four-bytes-robby deleted the fix/5-gh-issue-close-json-field branch September 5, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh_issue_close fails: unknown JSON field closedByPullRequestsUrls

1 participant