Conversation
mguida22
left a comment
There was a problem hiding this comment.
Looks good once the API changes land and the doc comments are updated
Co-authored-by: Mike Guida <guida@foxglove.dev>
gasmith
left a comment
There was a problem hiding this comment.
Thanks for the doc string adjustments; should've caught that myself.
@mguida22: We should be safe to merge this before the API changes land, right? The API server ignores superfluous query parameters. |
Oh yup, you're right. I was thinking that it would be misleading to accept |
This is one of several changes to relax the device naming constraint to be scoped to a project, instead of an org. This change updates the python client to expose a
project_idparameter for various device endpoints.