Conversation
Contributor
|
What you have here looks great, but what do you think about adding support for updating an existing event as well? My thinking is that if we're suggesting users to use code to patch events before removing an event type / custom property, then it would be friendlier to support it in the Python package as well. (I can only find a |
52e236e to
6d2c565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Introduces
update_eventand adds support for event types and event properties to existing event functions.See event API docs to learn more.
Docs
https://github.com/foxglove/docs/pull/1035/
Description
Adds support for new event API behavior. Events can now belong to an event type and an event can have typed properties, similar to devices.