fix: Record inputs after gathering in after_tick#614
Merged
elementbound merged 5 commits intoJul 4, 2026
Conversation
elementbound
force-pushed
the
fix-one-off-input-recording
branch
2 times, most recently
from
75eac1f to
0fde29e
Compare
elementbound
changed the title
after_tick_loop
elementbound
changed the title
after_tick_loopafter_tick
elementbound
force-pushed
the
fix-one-off-input-recording
branch
from
2e46926 to
d5661ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit d6ddde4 broke the one off input gathering.
One off inputs are recorded on NetworkTİme.after_tick.
Before that* commit rollback inputs were recorded from rbs after_tick.
After that commit rollback inputs are recorded from network-rollback after_tick.
Godot calls signals based on their connected order.
Before server update rbs's were connecting their signals with a deferred call. This was resulting in one off input node winning the race. But after the server update, since servers are initialized before anything else, input nodes are always losing the race.
This pr fixes the race condition by introducing gather_one_off_inputs signal on NetworkRollback. Signal is emitted just before recording/synchronizing inputs.
Docs are updated with 1 note
Examples using gather_always changed to use this new signal.