Improve test coverage and fix signal registration bug - #40
Merged
Conversation
The post_delete receiver in books/signals.py was never connected because the module was not imported during app startup. Add the import in BooksConfig.ready() so the receiver is properly registered. Add tests covering the delete_recording_file signal handler for all file cleanup paths.
Cover BookAdmin, NarratorAdmin, RecordingAdmin, QRCodeAdmin, EventCodeAdmin, and InviteLinkAdmin including get_exclude, get_fields, custom actions, and display methods.
Cover missing audio_file, missing raw file on disk, QR creation failure resilience, spawn_remux thread behavior, and recover_pending_recordings integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
books/signals.pypost_delete receiver was never connected (module not imported in AppConfig.ready())Test plan
docker compose run --rm test)ruff check .)