Skip to content

Allow narrators to re-record flagged recordings - #41

Merged
AevumDecessus merged 2 commits into
fragforce:devfrom
AevumDecessus:narrator-rerecord
Jun 29, 2026
Merged

Allow narrators to re-record flagged recordings#41
AevumDecessus merged 2 commits into
fragforce:devfrom
AevumDecessus:narrator-rerecord

Conversation

@AevumDecessus

@AevumDecessus AevumDecessus commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Narrators can now re-record a book directly from a flagged recording's detail page
  • Previously flagged recordings are automatically deleted when a new recording is uploaded for the same book
  • Flagged recordings no longer count toward a book's max_narrators limit

Test plan

  • All 145 tests pass (docker compose run --rm test)
  • Lint passes (ruff check .)
  • CI and SonarCloud quality gate pass

Add a "Re-record this book" link on the flagged recording detail page. When a narrator uploads a new recording for a book, any previously flagged recordings for that book are deleted. Flagged recordings no longer count toward max_narrators limits.
Cover flagged recording dashboard visibility, max_narrators exclusion of flagged recordings, re-record link presence, and cleanup of flagged recordings on re-upload.
@AevumDecessus
AevumDecessus merged commit 47c36b7 into fragforce:dev Jun 29, 2026
3 checks passed
@AevumDecessus
AevumDecessus deleted the narrator-rerecord branch June 29, 2026 20:29
@sonarqubecloud

Copy link
Copy Markdown

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants