-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Speakeasy API client bootstrap (PDE-755) #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,14 +21,20 @@ jobs: | |
| - name: Install package | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -e . | ||
| # Pre-generation the repo has no installable package yet; the verify | ||
| # tests import from src/ directly (PYTHONPATH below). | ||
| pip install -e . || echo "editable install unavailable (pre-generation); continuing" | ||
| pip install pytest | ||
|
|
||
| - name: Verify hand-written modules are present | ||
| run: | | ||
| test -f convoy/utils/webhook.py | ||
| test -f src/convoy/utils/webhook.py | ||
| test -f test/signature-vectors.json | ||
| test -f test/test_shared_vectors.py | ||
|
|
||
| - name: Execute verify + shared vector tests | ||
| env: | ||
| # PEP 420 namespace packages: `convoy.utils.webhook` resolves from | ||
| # src/ before generation adds real __init__.py files. | ||
| PYTHONPATH: src | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CI masks install failuresMedium Severity The workflow always ignores Reviewed by Cursor Bugbot for commit df6e2a7. Configure here. |
||
| run: pytest test/test_webhook.py test/test_shared_vectors.py -q | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Webhook package init removed
High Severity
src/convoy/utils/webhook.pyis relocated without a hand-ownedsrc/convoy/utils/__init__.py, and.genignoreno longer preserves one. Speakeasy/hatchlingpackage discovery often skips subpackages that lack__init__.py, so the published wheel can omit webhook verify while localPYTHONPATHimports still work.Reviewed by Cursor Bugbot for commit df6e2a7. Configure here.