Skip to content

Hubspot: add plugin menu#332

Merged
madebyisaacr merged 4 commits intomainfrom
hubspot-menu
Jul 28, 2025
Merged

Hubspot: add plugin menu#332
madebyisaacr merged 4 commits intomainfrom
hubspot-menu

Conversation

@madebyisaacr
Copy link
Copy Markdown
Collaborator

@madebyisaacr madebyisaacr commented Jul 18, 2025

Description

This pull request adds a plugin menu to the HubSpot plugin with a Log Out button.

Closes #323

Other changes:

  • Fixed plugin having wrong height in canvas view, resulting in the bottom buttons being clipped.
    Pasted Graphic embed widgets and much more

  • Fixed content not being centered in sign in view.
    HubSpot (Development) HubSpot (Development)

Testing

  • When not signed in, there is no menu
  • When signed in, there is a menu with a Log Out button
  • Test in canvas and managed collection modes

@madebyisaacr
Copy link
Copy Markdown
Collaborator Author

Note: I had to do this to make logging in work without errors when testing on localhost. It runs fine in production without these changes.

image

@madebyisaacr
Copy link
Copy Markdown
Collaborator Author

Should we make logging out keep the plugin open and go back to the log in screen, instead of closing it?

@kaloyanvi
Copy link
Copy Markdown
Collaborator

Should we make logging out keep the plugin open and go back to the log in screen, instead of closing it?

Yes, for sure!

Comment thread plugins/hubspot/src/App.tsx
@tom-james-watson
Copy link
Copy Markdown
Contributor

This seems to have a lot of issues running locally at the moment that are unrelated to the PR. Getting a bunch of valibot errors.

Copy link
Copy Markdown
Contributor

@elmarburke elmarburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Great one, code looks good
(I've updated one bit for wording about removing the plugin)

@elmarburke
Copy link
Copy Markdown
Contributor

We need to look into the validation issue, the current version fails authentication for me — that's what you, @madebyisaacr, mention for local running it as well.

@madebyisaacr madebyisaacr added this pull request to the merge queue Jul 28, 2025
@madebyisaacr
Copy link
Copy Markdown
Collaborator Author

madebyisaacr commented Jul 28, 2025

Merging now so the code on main matches the current live version (update was published a few days ago).

I'll open issues for the other feedback - log out flow and other errors.

Merged via the queue into main with commit b79afcc Jul 28, 2025
5 checks passed
@madebyisaacr madebyisaacr deleted the hubspot-menu branch July 28, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add menu to Hubspot

4 participants