fix: restore node/vite type resolution under TypeScript 7 - #1686
Merged
Conversation
TypeScript 7 no longer auto-includes @types packages the way 5.x did, and it now errors on side-effect imports (e.g. CSS) that resolve only through ambient module declarations shipped by vite/client. Declare "types" explicitly so tsc keeps finding @types/node and vite/client. Also drops the now-unused, no-longer-supported `baseUrl` compiler option (TS7 removed it) from the dashboard tsconfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chore: typescript@^7.0.2).@types/nodethe way 5.x did (build failed withCannot find name 'process'/'Buffer'/'node:path'etc. acrosssrc/dashboard/*), and it now errors (TS2882) on side-effect imports — like CSS files — that only resolve through ambient module declarations shipped byvite/client."types": ["node"]to the sharedtsconfig.base.json, and"vite/client"to the two Vite-based tsconfigs (packages/framework/dashboard/tsconfig.json,packages/the-framework.ai/tsconfig.json) sotsckeeps resolving Node globals and CSS imports.baseUrlfrompackages/framework/dashboard/tsconfig.json— TS7 removed support for it (TS5083), and nothing in the dashboard relies on it (no non-relative imports depend onbaseUrlresolution).Test plan
pnpm installpnpm buildpnpm typecheckpnpm testThis branch targets
brillout/dev(the head of #1684) so merging it directly resolves that PR's CI failure.Generated by Claude Code