fix(activities): Notes tab was showing every synced email and meeting - #5
Merged
Conversation
… email/meeting NOTE_TYPES fed the "Notes" tab's filter clause, but included EMAIL and MEETING alongside NOTE/CALL -- both of which already have their own dedicated tab. Effect: every synced email and every synced meeting also showed up under Notes, which its own empty-state copy describes as "what you write down for the next person to read" -- i.e. manual entries only. Found investigating a report that "all mail lands in the notes channel" after the contact-history backfill made Notes tab traffic visible for the first time (previously the tab was empty because the live sync had never stored anything). NOTE_TYPES narrowed to [NOTE, CALL] -- the two types with no dedicated tab of their own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOTE_TYPES(backing the Notes tab's filter clause inactivities.service.ts) includedActivityType.EMAILandActivityType.MEETINGalongsideNOTE/CALL-- both of which already have their own dedicated tab (email,meetings). Every synced email and meeting was therefore also showing up under Notes, contradicting the tab's own empty-state copy ("Notes are what you write down for the next person to read").NOTE_TYPESnarrowed to[NOTE, CALL]-- the two types with no dedicated tab of their own.Test plan
activities-timeline-filter.spec.ts, 5 cases (notes tab scoped correctly, email/meetings/all tabs unaffected,timelineCounts.notesmatches)apps/apisuite: 429 pass / 1 fail (the pre-existing, unrelatedauth.e2e.spec.tsflake)bun run check-typescleanNot yet deployed -- vigiep1 is at ~97% disk (separate issue,
/var/lib/containerdbloat under investigation), holding off on a rebuild until that's resolved. Same--no-verifyprecedent as the last 2 PRs.