Improve flow modal buttons (better error feedback)#8625
Merged
Conversation
Firefox can now open flows in a new tab, downloading or copying too big of a flow image still doesn't work. I give up on trying to put more energy into it.
Matthbo
changed the title
|
philipsens
approved these changes
Mar 19, 2025
Member
|
Could this benefit from an e2e test? |
nielsm5
approved these changes
Mar 20, 2025
Member
Probably yes, but I think we've spent enough time on this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox can now open flows in a new tab, downloading or copying too big of a flow image still doesn't work. I give up on trying to put more energy into it.