chore(deps): update dependency systeminformation@<5.30.8 to >=5.31.6 [security]#587
Open
renovate[bot] wants to merge 1 commit into
Open
chore(deps): update dependency systeminformation@<5.30.8 to >=5.31.6 [security]#587renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR contains the following updates:
>=5.30.8→>=5.31.6Systeminformation vulnerable to Linux command injection in networkInterfaces() via unsanitized NetworkManager connection profile name
CVE-2026-44724 / GHSA-hvx9-hwr7-wjj9
More information
Details
Summary
On Linux,
systeminformationis vulnerable to command injection innetworkInterfaces()when an active NetworkManager connection profile name contains shell metacharacters.This is not caused by a caller passing attacker-controlled arguments into
networkInterfaces(). The vulnerable value is obtained internally from realnmcli device statusoutput. The library sanitizes the network interface name before using it in shell commands, but it does not apply equivalent sanitization to the parsed NetworkManager connection profile name. That unsanitizedconnectionNameis then interpolated into three shell command strings executed throughexecSync().This issue was validated locally against real NetworkManager and real
nmcli. Calling only:was enough to trigger execution. The injected command ran with the privileges of the calling Node.js process.
Affected Component & Versions
Affected component:
lib/network.jsnetworkInterfaces()nmclihandlingImpact & Threat Model
Confirmed impact:
An attacker who can create or rename an active NetworkManager connection profile can execute arbitrary shell commands when a Node.js process using
systeminformationcallsnetworkInterfaces().Confirmed realistic affected deployments include:
If such a process runs with elevated privileges, the injected command executes with those same elevated privileges.
Confirmed facts:
nmcli device statusreturned the name unchanged.networkInterfaces()parsed that value and reused it in shell commands.Not claimed:
AV:NorAV:Aclaim is made..nmconnectionimport was not confirmed as a remote or unauthenticated path.Root Cause Analysis
The root cause is inconsistent trust handling between the Linux interface name and the NetworkManager connection profile name.
The interface name is sanitized before it is embedded into shell commands:
However, the NetworkManager connection name is parsed from command output and later reused without equivalent sanitization:
That is unsafe because NetworkManager profile names can contain shell metacharacters. Quoting the value inside
"${connectionName}"does not make it safe. A connection name containing",$(),;, backticks, or similar shell syntax can break out of the intended argument context or trigger command substitution.The vulnerable code executes through
execSync(), which invokes a shell for command strings. As a result, interpolatingconnectionNameinto the command string creates a command-injection sink.Exact Code Flow & File Paths
Source:
lib/network.js:538-544The parsed value is then returned as
connectionName.Trigger:
lib/network.js:987-991Sink 1:
lib/network.js:620Sink 2:
lib/network.js:660Sink 3:
lib/network.js:676There are three distinct exploitable
connectionNamesinks.Proof of Concept (PoC) & Reproduction Steps
The following PoC is harmless and local-only. It uses a dummy NetworkManager connection and writes proof files under /tmp.
Run from the project root:
cd /path/to/systeminformationConfirm proof files do not already exist:
Create a malicious NetworkManager dummy profile:
Assign a documentation-only address so Node’s os.networkInterfaces() sees the dummy interface:
nmcli connection modify 'si-ghsa$(id>/tmp/si-nm-id-proof)$(pwd>/tmp/si-nm-pwd-proof)$(env>/tmp/si-nm-env-proof)' \ ipv4.method manual \ ipv4.addresses 192.0.2.253/32 \ ipv6.method disabledActivate the profile:
nmcli connection up 'si-ghsa$(id>/tmp/si-nm-id-proof)$(pwd>/tmp/si-nm-pwd-proof)$(env>/tmp/si-nm-env-proof)'Confirm real nmcli exposes the malicious connection name unchanged:
nmcli device status | grep si-nmghsa0Expected relevant output includes the active connection name:
Trigger the vulnerable library path with no attacker-controlled function argument:
Confirm command execution:
Inspect environment key categories without printing secret values:
validated evidence:
Local Validation Summary & Aggregate Reachability
Validation was performed against real NetworkManager and real
nmcli. The primary proof did not rely on a PATH stub.Observed behavior:
nmcli device status.require('./lib').networkInterfaces()triggered execution.idoutput matched the calling Node.js process identity.pwdoutput matched the Node.js process working directory.Aggregate API reachability:
lib/index.js:94:getStaticData()reachesnetwork.networkInterfaces()as part of static data collection.lib/index.js:307:getAllData()reachesgetStaticData()first.During local validation, an aggregate runtime attempt later hit an unrelated
osinfo.jserror in that environment. Because of that, aggregate source reachability is confirmed, but aggregate call completion was not used as the primary exploit proof.Why This Is Not Intended Behavior
networkInterfaces()is documented and expected to return network interface metadata such as interface name, IP addresses, DHCP state, DNS suffix, and IEEE 802.1X status.The library already shows an intent to protect shell command construction by sanitizing interface names before shell use. The missing sanitization for
connectionNameis inconsistent with that defensive pattern.Executing shell commands embedded in a NetworkManager profile name is not a documented feature, not required to return network metadata, and not an expected design tradeoff. This is a command injection vulnerability caused by unsafe shell-string construction.
Recommended Fix
Avoid shell interpolation entirely for NetworkManager calls.
Replace shell command strings with
execFileSync()orspawnSync()using argument arrays. For example:Recommended code-level changes:
nmcli device status 2>/dev/null | grep ${interfaceName}with argument-array execution and filter rows in JavaScript.nmcli connection show "${connectionName}" | grep ...shell string with argument-array execution.ipv4.method,ipv4.dns-search, and802-1x.eapin JavaScript instead of using shellgrep.Regression Test Ideas
Add Linux-specific tests for NetworkManager connection names containing shell metacharacters.
Suggested malicious connection names:
name$(...)name"; ...; #name|...name;...Expected behavior after the fix:
networkInterfaces()completes without executing shell syntax from the connection name.For unit-level coverage, mock the NetworkManager command wrapper so that
nmcli device statusreturns a connection name containing metacharacters, then assert that subsequent calls use argument arrays rather than shell strings.Credit request
If you publish an advisory or assign a CVE, please credit me as:
Ali Firas (thesmartshadow) - https://www.smartshadow.dev
Severity
CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:HReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
sebhildebrandt/systeminformation (systeminformation@<5.30.8)
v5.31.6Compare Source
Full Changelog: sebhildebrandt/systeminformation@v5.31.5...v5.31.6
v5.31.5Compare Source
Full Changelog: sebhildebrandt/systeminformation@v5.31.4...v5.31.5
v5.31.4Compare Source
Full Changelog: sebhildebrandt/systeminformation@v5.31.3...v5.31.4
v5.31.3Compare Source
Full Changelog: sebhildebrandt/systeminformation@v5.31.2...v5.31.3
v5.31.2Compare Source
Full Changelog: sebhildebrandt/systeminformation@v5.31.1...v5.31.2
v5.31.1Compare Source
Full Changelog: sebhildebrandt/systeminformation@v5.31.0...v5.31.1
v5.31.0Compare Source
Full Changelog: sebhildebrandt/systeminformation@v5.30.8...v5.31.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.