Skip to content

fix(nginx): Remove unclosed string from headers - #591

Merged
ssiyad merged 1 commit into
developfrom
fix/nginx/headers_methods_quotes
Aug 25, 2026
Merged

fix(nginx): Remove unclosed string from headers#591
ssiyad merged 1 commit into
developfrom
fix/nginx/headers_methods_quotes

Conversation

@ssiyad

@ssiyad ssiyad commented Aug 25, 2026

Copy link
Copy Markdown
Member

This commit fixes unclosed strings in headers:

  • Access-Control-Allow-Headers
  • Access-Control-Allow-Methods

Currrent:

access-control-allow-headers
'Origin, Content-Type, Accept

access-control-allow-methods
'GET, POST, OPTIONS

This commit fixes unclosed strings in headers:

- `Access-Control-Allow-Headers`
- `Access-Control-Allow-Methods`
@ssiyad
ssiyad requested a review from balamurali27 August 25, 2026 08:22
@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge.

The corrected values remain valid Nginx strings and produce properly formed CORS response headers.

Reviews (1): Last reviewed commit: "fix(nginx): Remove unclosed string from ..." | Re-trigger Greptile

@mergify

mergify Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@ssiyad
ssiyad merged commit f9e88ff into develop Aug 25, 2026
6 checks passed
@ssiyad
ssiyad deleted the fix/nginx/headers_methods_quotes branch August 25, 2026 08:29
@ssiyad

ssiyad commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

@mergify backport master

@mergify

mergify Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

backport master

❌ No backport have been created

Details
  • Backport to branch master failed

Git reported the following error:

To https://github.com/frappe/agent
 ! [rejected]        mergify/bp/master/pr-591 -> mergify/bp/master/pr-591 (fetch first)
error: failed to push some refs to 'https://github.com/frappe/agent'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

ssiyad added a commit that referenced this pull request Aug 25, 2026
fix(nginx): Remove unclosed string from headers (backport #591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant