Skip to content

fix: select dropdown rendering as text input in overflow#541

Merged
surajshetty3416 merged 3 commits intofrappe:developfrom
Vibhuti410:overflow-select-dropdown
Apr 17, 2026
Merged

fix: select dropdown rendering as text input in overflow#541
surajshetty3416 merged 3 commits intofrappe:developfrom
Vibhuti410:overflow-select-dropdown

Conversation

@Vibhuti410
Copy link
Copy Markdown
Collaborator

@Vibhuti410 Vibhuti410 commented Mar 31, 2026

Declared types and options as props so it reaches the input component and renders the dropdwon correctly.

Before:

before.mov

After:

after.mov

Fixes: #501

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.93%. Comparing base (af06b98) to head (aa4d5be).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #541   +/-   ##
========================================
  Coverage    57.93%   57.93%           
========================================
  Files           28       28           
  Lines         3105     3105           
========================================
  Hits          1799     1799           
  Misses        1306     1306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416 surajshetty3416 marked this pull request as draft April 1, 2026 07:58
@Vibhuti410 Vibhuti410 marked this pull request as ready for review April 17, 2026 10:05
@surajshetty3416
Copy link
Copy Markdown
Member

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2026

update

✅ Branch has been successfully updated

@surajshetty3416 surajshetty3416 merged commit 9b4feea into frappe:develop Apr 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overflow x is a free text field instead of dropdown

2 participants