fix: remove clientScript from page's block json - #663
Conversation
Confidence Score: 5/5Logic is correct and the migration path handles both legacy and new data formats safely. The clientScript reset + conditional merge in extend_block correctly mirrors how other attributes are handled. The legacy migration uses a falsy check so an empty {} still triggers it. No data-loss or incorrect-merge path identified. No files require special attention. Reviews (2): Last reviewed commit: "fix: handle case where both legacy and c..." | Re-trigger Greptile |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #663 +/- ##
========================================
Coverage 56.53% 56.54%
========================================
Files 34 34
Lines 4109 4119 +10
========================================
+ Hits 2323 2329 +6
- Misses 1786 1790 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Before this the component's
clientScriptswould be duplicated in the page's block JSON instead of being extended from the component block itself.This PR fixes that and makes the
clientScriptattribute behave similar to how all other block attributes behave when extended from a component — not present in block JSON unless overridden.