Skip to content

feat: align border control with spacing split-mode inputs - #686

Merged
surajshetty3416 merged 1 commit into
frappe:developfrom
SmrutiSawant:feature
Jul 22, 2026
Merged

feat: align border control with spacing split-mode inputs#686
surajshetty3416 merged 1 commit into
frappe:developfrom
SmrutiSawant:feature

Conversation

@SmrutiSawant

Copy link
Copy Markdown
Contributor

Replaced the individual border properties with a unified BorderControl component that supports splitting the border width inputs into T(top), R(right), B(bottom), L(left) side inputs (matching the existing Spacing and Border Radius fields layout)

@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

Safe to merge; the change is additive and the core split-mode wiring is correct.

The split-mode integration and color-event cleanup logic are sound. The only difference from the original behavior is that Border Style becomes visible when borderWidth is set without a borderColor, which is a minor UX edge case rather than a data-corrupting bug.

frontend/src/components/BorderControl.vue — specifically the hasColor computed property condition.

Reviews (1): Last reviewed commit: "feat: align border control with spacing ..." | Re-trigger Greptile

Comment thread frontend/src/components/BorderControl.vue
@surajshetty3416

Copy link
Copy Markdown
Member

@SmrutiSawant always better to add screenshots/video to demonstrate the change

@SmrutiSawant

Copy link
Copy Markdown
Contributor Author

Screen recording demonstrating the new unified Border properties and the split-mode width inputs
Before :

Before.mp4

After:

after.mp4

@mergify

mergify Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@surajshetty3416
surajshetty3416 merged commit c1bfbef into frappe:develop Jul 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants