Skip to content

feat: font dropdown keeps a minimum width - #771

Merged
surajshetty3416 merged 1 commit into
frappe:developfrom
surajshetty3416:font-dropdown-min-width
Aug 19, 2026
Merged

feat: font dropdown keeps a minimum width#771
surajshetty3416 merged 1 commit into
frappe:developfrom
surajshetty3416:font-dropdown-min-width

Conversation

@surajshetty3416

@surajshetty3416 surajshetty3416 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Overview

A narrow Family input forces its own width on the font options list, so family names rendered in their own typeface get truncated (Do... Space Mono, Wi...Unbounded). The options list now has a width floor.

Screenshot

Family dropdown wider than its input, right-aligned, labels no longer truncated

Details

  • Autocomplete takes an optionsMinWidth prop. The in-place (absolute) path applies it as min-width and anchors the list to the input's right edge, so the extra width grows toward the canvas instead of past the panel edge. The teleported (fixed) path bakes the floor into its explicit width and clamps left so the list stays in the viewport.
  • FontInput asks for a 240px floor; other autocompletes are unchanged.

A narrow Family input forced its own width on the options list, so
family names rendered in their own typeface got truncated. Autocomplete
takes an optionsMinWidth floor: the absolute path anchors right so the
extra width grows away from the panel edge, the fixed path widens its
explicit width and clamps left to stay in the viewport. FontInput asks
for 240px.

Co-Authored-By: Claude <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The new width floor preserves existing autocomplete behavior while keeping widened font menus aligned and viewport-clamped.

Reviews (1): Last reviewed commit: "feat: font dropdown keeps a minimum widt..." | Re-trigger Greptile

@surajshetty3416
surajshetty3416 merged commit 8692f58 into frappe:develop Aug 19, 2026
8 checks passed
@surajshetty3416
surajshetty3416 deleted the font-dropdown-min-width branch August 19, 2026 08:13
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.90%. Comparing base (544aaa2) to head (ce44226).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #771   +/-   ##
========================================
  Coverage    66.90%   66.90%           
========================================
  Files           92       92           
  Lines         9937     9937           
========================================
  Hits          6648     6648           
  Misses        3289     3289           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant