Skip to content

fix: duplicate a standard page as a plain page - #811

Merged
surajshetty3416 merged 1 commit into
frappe:developfrom
surajshetty3416:fix-duplicate-standard-page
Sep 9, 2026
Merged

fix: duplicate a standard page as a plain page#811
surajshetty3416 merged 1 commit into
frappe:developfrom
surajshetty3416:fix-duplicate-standard-page

Conversation

@surajshetty3416

Copy link
Copy Markdown
Member

Fixes #597

frappe.copy_doc keeps no_copy fields unless told otherwise, so duplicating a standard page carried is_standard and app over. Outside developer mode the copy then opened read-only, and inside it a second export was written for the same app. The duplicate now starts as a plain page: not standard, no app.

copy_doc keeps no_copy fields by default, so a duplicate of a standard
page carried is_standard and app over and opened read-only outside
developer mode. The duplicate is now a plain page.

Co-Authored-By: Claude <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

Safe to merge.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.89%. Comparing base (7d1ac04) to head (184d625).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #811      +/-   ##
===========================================
+ Coverage    66.86%   66.89%   +0.02%     
===========================================
  Files           94       94              
  Lines        10496    10505       +9     
===========================================
+ Hits          7018     7027       +9     
  Misses        3478     3478              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416
surajshetty3416 merged commit 50bfeed into frappe:develop Sep 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Duplicating Standard Pages makes a new Standard Page

1 participant