feat(object-storage): Publish gateway proxy routes - #30
Merged
Conversation
tanmoysrt
force-pushed
the
object-storage-proxy-routes
branch
from
September 11, 2026 12:50
3806ccb to
2257831
Compare
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The failure path of publish_proxy_routes passed ":str" as a format spec, so ProxyError.__format__ raised a TypeError instead of marking the cluster Failed. IntegrationTestLiveClusterRelease activates a cluster per test and the suite does not roll back between tests, so the new single-Active-cluster rule rejected the save inside release_machines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Writing the same site mapping twice is the same mapping, so a connection failure or a 429, 500, 502, 503 or 504 is asked again with a growing backoff. A refusal is the Proxy's answer and raises on the first attempt. This narrows the window where one of the two service domains is published and the other is not. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ObjectStorageCluster interpolated the stored value while ProxyClient normalised its own copy, so a value such as ".example.com" built a service domain that the Proxy then refused. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The Frappe Semgrep security rules block an exception object passed straight to .format() on a translated string. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tanmoysrt
force-pushed
the
object-storage-proxy-routes
branch
from
September 11, 2026 13:05
355bc15 to
e5dec47
Compare
Aradhya-Tripathi
added a commit
that referenced
this pull request
Sep 11, 2026
Brings in the proxy route publishing from #30 alongside the gateway nginx step. The setup flow now runs nginx on the gateway, verifies the nodes, then publishes proxy routes, and marks the cluster Active only once all three succeed. nginx comes first so the proxy is never given routes to a gateway that cannot take them. setup() keeps this branch's behaviour of always running the full flow: develop's "every node joined" shortcut re-published proxy routes but skipped nginx, so a failed nginx step could never be retried. install.py and setup.sh each carried WILDCARD_DOMAIN twice after the merge; one of each is kept. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GhqFzS8Bq8s8qK9r5x6bXr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo publishes the regional S3 and S3 administration domains through the Proxy before an object storage cluster becomes Active.
What changed
s3-svc.<wildcard-domain>ands3-admin-svc.<wildcard-domain>to the Garage gateway mesh address.-svcsuffix.Why
The regional S3 services need stable public domains without exposing arbitrary Proxy site-map authority.
Validation
test.local.Related issues
None.