chore(ui): Update frappe-ui version - #285
Merged
Merged
Conversation
Contributor
Confidence Score: 5/5The PR appears safe to merge because no eligible blocking failure remains. No blocking failure remains. Reviews (4): Last reviewed commit: "fix(ui): remove useless dynamic class in..." | Re-trigger Greptile |
# Conflicts: # dashboard/src/components/servers/ServerMap.vue
siduck
pushed a commit
that referenced
this pull request
Aug 14, 2026
frappe-ui's SettingsDialog declares its open state as a named model
(`defineModel('open')`) and no longer accepts a bare `modelValue`. The
rename landed in v1.0.0-beta.52; #285 moved this app from beta.24 to
beta.53 and crossed it.
A bare `v-model` therefore writes to a prop nothing reads, and Vue does
not warn — so desktop settings simply stops opening. Bind the model it
actually declares.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.