feat: Add recipe for datum builds - #5
Merged
Merged
Conversation
datum now ships a migration runner: it owns the database, both tables and both ClickHouse users, and datum-api issues no DDL at all. Its lifespan pings the store and refuses to start when the schema is missing, so migrations have to run before the unit does. - drop users.sql.j2; datum/migrations/000_acl.sql creates both users - enable_access_management() keeps the users.d drop-in, since datum-migrate issues CREATE USER and a stock install disallows it - run_migrations() renders a 0600 script, runs it, deletes it: pyinfra logs the command it runs, so the insights password goes in the file, not the argv - build order puts run_migrations after write_env_file (the migration reads DATUM_CLICKHOUSE_PASSWORD from it to create the datum user) and before install_unit - env file drops DATUM_CLICKHOUSE_DATABASE and DATUM_CLICKHOUSE_TABLE, which Settings no longer reads, and gains DATUM_TIMEOUT - passwords are token_hex, not token_urlsafe: datum-migrate refuses a password containing `--`, which token_urlsafe emits about 0.8% of the time - verify asserts both tables exist rather than crediting ensure_schema Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add datum build configs with clickhouse setup and datum service setup.