Skip to content

fix: propagate no_of_employees to organization on lead/deal conversion - #2751

Merged
ps173 merged 2 commits into
frappe:developfrom
Shindhu-Ramaswamy:fix-2744-organization-employee-count
Sep 7, 2026
Merged

fix: propagate no_of_employees to organization on lead/deal conversion#2751
ps173 merged 2 commits into
frappe:developfrom
Shindhu-Ramaswamy:fix-2744-organization-employee-count

Conversation

@Shindhu-Ramaswamy

@Shindhu-Ramaswamy Shindhu-Ramaswamy commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

The employee count entered on a Lead or Deal was getting lost when it was converted into an Organization — it either wasn't copied at all, or got silently reset to the default 1-10. This fix passes no_of_employees through in both conversion paths so the value carries over correctly.

closes : #2744

@mergify

mergify Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.21%. Comparing base (fa9f3a1) to head (143d7b5).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2751      +/-   ##
===========================================
+ Coverage    69.19%   69.21%   +0.02%     
===========================================
  Files          177      177              
  Lines        12165    12176      +11     
===========================================
+ Hits          8417     8428      +11     
  Misses        3748     3748              
Files with missing lines Coverage Δ
crm/fcrm/doctype/crm_deal/crm_deal.py 90.41% <ø> (ø)
crm/fcrm/doctype/crm_deal/test_crm_deal.py 98.01% <100.00%> (+0.04%) ⬆️
crm/fcrm/doctype/crm_lead/crm_lead.py 90.26% <ø> (ø)
crm/fcrm/doctype/crm_lead/test_crm_lead.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The previously reported propagation-coverage gap is resolved, and no blocking failure remains.

Reviews (2): Last reviewed commit: "test: add regression coverage for no_of_..." | Re-trigger Greptile

Comment thread crm/fcrm/doctype/crm_deal/crm_deal.py

@ps173 ps173 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ps173
ps173 merged commit 3943912 into frappe:develop Sep 7, 2026
14 checks passed
ps173 added a commit that referenced this pull request Sep 8, 2026
fix: propagate no_of_employees to organization on lead/deal conversion (backport #2751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Organization default employee count should respect the source

3 participants