fix: drop Home's end-of-list marker, word each empty view for its tab - #374
Merged
Conversation
Home closed every populated view with "You've reached the end · made with Frappe Draw". It told the user nothing they could act on, and anyone who met it before scrolling read it as an empty state. It is gone. The empty views carry the message instead, and each is now worded for its own tab. Home is the one that reads as an invitation rather than a report — "Start a drawing" — because the Create button is right there and a first-time user lands on it with nothing. Recent, Shared and Pinned each say what belongs there. A search that matches nothing still wins over the tab wording, since the query is what excluded the rows. The set moves to homeViews.js, next to the nav and the view titles, so the copy is unit-testable without mounting the grid — the reason that module exists. An unknown mode falls back to Home rather than rendering an undefined icon. Closes #220 Co-authored-by: Vibhav Katre <vibhav@frappe.io> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home closed every populated view with:
It told the user nothing they could act on, and anyone who met it before scrolling
read it as an empty state. It is gone.
The empty views carry the message instead
Each is now worded for its own tab, because "empty" means something different in
each one:
Home is the only one that reads as an invitation rather than a report. The Create
button is right there, and a first-time user lands on it with nothing.
A search that matches nothing still wins over the tab wording, since the query is
what excluded the rows — "No pinned diagrams" would be wrong when the tab does have
pins.
Where the copy lives
The set moves to
homeViews.js, next to the nav and the view titles, so it isunit-testable without mounting the grid. That is the reason the module exists:
An unknown mode falls back to Home rather than rendering an undefined icon. A test
walks the nav set and fails if a view is ever added without an empty state.
Verification
Driven live on Home:
a populated Home no longer ends with the marker
the Shared tab, with nothing in it, shows its own wording
a search matching nothing says "No diagrams match", not the tab wording
yarn test— 879 pass, 8 new checksyarn build— cleanCloses #220