feat: drop the type glyph from Home's list rows - #375
Merged
Conversation
Every list row drew the same lucide-shapes glyph. Types stopped being a user-facing concept in #114, which replaced the per-type icons with one neutral one, so what remained distinguished nothing and only pushed the titles right. The header's matching spacer lane goes with it. The header aligns column-for-column with the rows, so leaving the spacer would have shifted every heading one lane right of its column. Verified live: no glyph is left on any row, and the "Name" heading still sits exactly over the titles (both at x=112). Closes #218 Co-authored-by: Vibhav Katre <vibhav@frappe.io> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every list row drew the same
lucide-shapesglyph.Types stopped being a user-facing concept in #114, which replaced the per-type
icons with one neutral icon. What remained distinguished nothing between rows and
only pushed the titles right.
The header spacer goes too
The list header aligns column-for-column with the rows and reserved a matching
w-8lane for the glyph. Leaving it would have shifted every heading one laneright of its column, so both go together. The
w-6pin lane stays, since the rowsstill have a pin button.
Verification
Driven live on Home in list view:
lucide-shapeselement is left anywhere on the pageline up
A test asserts both halves, including that the spacer is gone — the alignment is
the part that breaks quietly.
yarn test— 90 files pass, 3 new checksyarn build— cleanCloses #218