fix: rebuild the connector menu as one kind of control

[vibhavkatre]

Five reports on the connector's edit menu. Four edit the same file and two touch the same import line, so they land together — as the issues themselves flag.

What changed

#493 — Dash and Corners were segmented controls carrying words, sitting directly below three rows of icon cells. Both are icon cells now.

• Dash needed no artwork, as the issue suggested: the cell draws the pattern with the same stroke-dasharray rule ConnectorView paints, at this connector's own width. So it previews this line rather than illustrating "dashed" generically.
• Corners did need artwork — one L-bend drawn twice, rounded and square, so the pair is read by its corner rather than by two different figures. It was not in the report; converting only the dash row would have left the identical inconsistency one line below.

#490 — the Arrow endpoint icon drew lucide-arrow-right, a stroked shaft with two open diagonals, while ConnectorMarker produces M0,0 L10,5 L0,10 z — a solid triangle. It takes a drawn glyph with the marker's own 1:1 proportions, fill-only (a stroke would round its point off against the caps the glyph sets). Open keeps its chevron: that endpoint really is stroked on the canvas.

#494 — line colour was the last control in the app still asking for a hex. It takes the Espresso grid that fill, border and text colour already use. allow-none is false: the grid emits 'none' in fill mode and a connector with no stroke colour would vanish. The default #7C7C7C is still in the grey family after #481 moved it, so the row shows as selected — verified, since the issue asked.

#492 — the label field is gone. Double-click already opened a label on both hit targets, focused and text-selected. setLabel went with it; the inline editor writes through updateConnector directly, so nothing else called it. The known trade stands: nothing in the UI now announces that a connector can carry a label.

#491 — the menu's trigger stops using lucide-minus, the bar #457 had already concluded does not read as a line tool. It now previews the selected line — its own colour, weight and dash — the way Fill and Border preview theirs. The issue warned specifically against copying the insert glyph across, since the original complaint was that the two line controls looked alike; a preview contrasts with the insert glyph because it is not a generic mark at all, and it says which line is selected.

Tooltips

Every native :title in this file is gone — three of the four sites #497 lists. Width had no tooltip at all and now has one.

The menu carries its own TooltipProvider. This is the trap #497 flags: the menu opens in a Popover whose content is teleported out of the toolbar's provider, so without one the tooltips would match the toolbar's in looks but each wait out its own delay. Verified that Tooltip renders through TooltipTrigger as-child and portals its bubble, so the flex-1 cells keep their layout — no wrapper element lands in the row.

That leaves #497 with only the pen/highlighter TabButtons.

Checked by eye

Drawn glyphs and hand-built cells are not something a source assertion can judge, so I rendered the rows at real size and screenshotted them. Two things only showed up there, both fixed:

• the dotted preview was clipped — round caps overhang the viewBox by half the stroke, so the last dot was cut off
• the corner glyphs sat off-centre in the 24-box

Tests

connectorSection.test.js (12 new): no TabButtons and no TextInput survive; the dash row draws a pattern instead of naming it; Corners has drawn glyphs; no :title on any control; the provider is present; the label field and its setter are gone; the Espresso grid is used with allow-none false and the default stays a swatch; Arrow carries a glyph and Open keeps its chevron.

insertCatalog.test.js (3 new, on ShapeGlyph): the arrowhead is filled and closed with no stroke; the corner pair is the same bend twice, one curved; neither new family overrides the house 24-box, stroke-width or caps.

These strip comments before asserting — the comments in the file name the things being asserted gone, which is the trap the earlier QA round hit twice.

connector-menu.spec.js (3 new E2E): this menu had no end-to-end coverage at all, which is how it could be rebuilt with nothing to catch a menu that renders empty. Each draws a real connector and reads the persisted document: a dash cell writes style.dash through; no label field remains while the other rows still render; no text input remains and a swatch writes style.color through.

Full unit suite green: 1521 tests.

Closes #490
Closes #491
Closes #492
Closes #493
Closes #494

🤖 Generated with Claude Code