Canvas unification — Phase 4a: frame origin data model

[vibhavkatre]

What & why

First step of Phase 4 (mind maps & flowcharts as frames on the unified canvas). Data model only — each auto-layout sub-model gains a frame origin {x,y} (its top-left on the shared canvas). No rendering change yet; legacy single-type docs are unaffected since {0,0} = no offset (exactly how they render today).

Changes

• mindmapModel / flowchartModel: createEmptyMindMap / createFlowchart include origin: {x:0,y:0}.
• schema.js: createUnifiedDocument places frames at distinct default origins (mind map {600,200}, flowchart {600,700}) so populated frames don't stack on the block substrate or each other. Migration backfills origin {0,0} on older unified docs.

Testing

Build ✅ · 101 unit tests ✅ (adds frame-origin defaults + migration backfill cases). No model-shape regressions.

Next

Render the mind map / flowchart layers as positioned frames on the unified canvas (translate by origin), then wire in-frame interaction.

🤖 Generated with Claude Code

[greptile-apps]

Confidence Score: 4/5

Safe to merge for current rendering; the createMindMap() gap could bite Phase 4b when the renderer starts reading .origin.

createMindMap() ships without origin while createEmptyMindMap() has it. The schema only calls createEmptyMindMap() today, so nothing breaks now, but as soon as Phase 4b code reads .origin on any object that came from createMindMap(), it will silently get undefined rather than {0,0}.

frontend/src/diagram/mindmapModel.js — the createMindMap factory.

_{Reviews (1): Last reviewed commit: "Frappe Draw: canvas unification phase 4a..." | Re-trigger Greptile}

[greptile-apps]

createEmptyMindMap() and createFlowchart() already set origin: {x:0, y:0}, so createUnifiedDocument immediately overwrites those values. A clarifying comment (or passing origins as constructor params) would make the intent explicit rather than looking like a first-time set.

Suggested change

	export function createUnifiedDocument(presetName = DEFAULT_PRESET_NAME) {
	return createDiagramDocument(presetName, UNIFIED_DIAGRAM_TYPE)
	const document = createDiagramDocument(presetName, UNIFIED_DIAGRAM_TYPE)
	document.mindmap.origin = { x: 600, y: 200 }
	document.flowchart.origin = { x: 600, y: 700 }
	return document
	}
	export function createUnifiedDocument(presetName = DEFAULT_PRESET_NAME) {
	const document = createDiagramDocument(presetName, UNIFIED_DIAGRAM_TYPE)
	// Override the {0,0} defaults from the sub-model factories with distinct
	// non-overlapping origins so frames don't stack on the block substrate.
	document.mindmap.origin = { x: 600, y: 200 }
	document.flowchart.origin = { x: 600, y: 700 }
	return document
	}

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!