feat: show tool calls immediately while streaming - #70
Merged
Conversation
Contributor
Confidence Score: 5/5Safe to merge — the streaming path, upsert logic, and type annotations are all consistent and the The logic is tight: No files require special attention. Reviews (2): Last reviewed commit: "test: expect ToolCallBegin marker in str..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool cards used to appear only after the model finished streaming a call's arguments — a multi-second silent gap after a text block for calls with large arguments.
ToolCallBeginmarker the moment a call's name is known mid-stream.ToolStartedimmediately (name only), then re-emits it with the full arguments once they finish streaming, before the tool runs — so arguments show during execution, not only with the result.tool_startedupserts the card (create, then fill args).