fix: allow deleting Flow Model despite Session/Agent references - #71
Merged
Conversation
Contributor
Confidence Score: 5/5Safe to merge — adding Flow Session to ignore_links_on_delete is a minimal, targeted change that only relaxes the link-check for historical session references. The one-line change is narrowly scoped: sessions hold read-only historical bookkeeping links to Flow Model, so skipping the link check on delete is correct and carries no operational risk. No files require special attention. Reviews (2): Last reviewed commit: "fix: keep Flow Agent link check, only ex..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sessions and Agents keep a historical/required link to a Flow Model, which blocked deleting the model. Adds them to
ignore_links_on_deleteso the link check no longer blocks it.