Error during HRMS install to site: Employee: Options must be a valid DocType for field Employment Type in row 24

[kaineuy]

Information about bug

ran this command after bench get-app hrms

bench --site [site] install-app hrms

Module

HR

Version

erpnext 14.x.x-develop develop (d370c60)
frappe 15.x.x-develop develop (91dce0b)
hrms 16.0.0-dev develop (8d6b5d9)

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

App erpnext already installed

Installing hrms...
Setting up Frappe HR...
Installation for Frappe HR app failed due to an error. Please try re-installing the app or report the issue on https://github.com/frappe/hrms/issues/new if not resolved.
An error occurred while installing hrms: Employee: Options must be a valid DocType for field Employment Type in row 24
Traceback (most recent call last):
  File "apps/frappe/frappe/commands/site.py", line 468, in install_app
    _install_app(app, verbose=context.verbose, force=force)
  File "apps/frappe/frappe/installer.py", line 322, in install_app
    frappe.get_attr(after_install)()
  File "apps/hrms/hrms/install.py", line 21, in after_install
    raise e
  File "apps/hrms/hrms/install.py", line 9, in after_install
    setup()
  File "apps/hrms/hrms/setup.py", line 15, in after_install
    create_custom_fields(get_custom_fields())
  File "apps/frappe/frappe/custom/doctype/custom_field/custom_field.py", line 327, in create_custom_fields
    create_custom_field(doctype, df, ignore_validate=ignore_validate)
  File "apps/frappe/frappe/custom/doctype/custom_field/custom_field.py", line 293, in create_custom_field
    custom_field.insert()
  File "apps/frappe/frappe/model/document.py", line 310, in insert
    self.run_post_save_methods()
  File "apps/frappe/frappe/model/document.py", line 1120, in run_post_save_methods
    self.run_method("on_update")
  File "apps/frappe/frappe/model/document.py", line 952, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1318, in composer
    return composed(self, method, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1300, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
                              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 949, in fn
    return method_object(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/custom/doctype/custom_field/custom_field.py", line 205, in on_update
    validate_fields_for_doctype(self.dt)
  File "apps/frappe/frappe/core/doctype/doctype/doctype.py", line 1189, in validate_fields_for_doctype
    validate_fields(meta)
  File "apps/frappe/frappe/core/doctype/doctype/doctype.py", line 1627, in validate_fields
    check_link_table_options(meta.get("name"), d)
  File "apps/frappe/frappe/core/doctype/doctype/doctype.py", line 1264, in check_link_table_options
    frappe.throw(
  File "apps/frappe/frappe/__init__.py", line 592, in throw
    msgprint(
  File "apps/frappe/frappe/__init__.py", line 564, in msgprint
    _raise_exception()
  File "apps/frappe/frappe/__init__.py", line 515, in _raise_exception
    raise exc
frappe.core.doctype.doctype.doctype.WrongOptionsDoctypeLinkError: Employee: Options must be a valid DocType for field Employment Type in row 24

Code of Conduct

• I agree to follow this project's Code of Conduct

[ruchamahabal]

Is this docker installation? Manual install works fine for me. Also please check your versions:
erpnext 14.x.x-develop develop (d370c60)
frappe 15.x.x-develop develop (91dce0b)
hrms 16.0.0-dev develop (8d6b5d9)

Use all v15 or develop(v16)

[Maree27]

I am also facing the same error on erpnext version 15
I am using ubuntu

[Maree27]

Installing hrms...
Setting up Frappe HR...
Installation for Frappe HR app failed due to an error. Please try re-installing the app or report the issue on https://github.com/frappe/hrms/issues/new if not resolved.
An error occurred while installing hrms: Employee: Options must be a valid DocType for field Employment Type in row 24
Traceback with variables (most recent call last):
File "apps/frappe/frappe/commands/site.py", line 462, in install_app
_install_app(app, verbose=context.verbose, force=force)
context = {'sites': ['glarahome.ca'], 'force': False, 'verbose': False, 'profile': False}
apps = ('hrms',)
force = False
_install_app = <function install_app at 0x7f5a3bfb0400>
filelock = <function filelock at 0x7f5a3bfa6480>
exit_code = 0
site = 'glarahome.ca'
app = 'hrms'
err = WrongOptionsDoctypeLinkError('Employee: Options must be a valid DocType for field Employment Type in row 24')
File "apps/frappe/frappe/installer.py", line 311, in install_app
frappe.get_attr(after_install)()
name = 'hrms'
verbose = False
set_as_patched = True
force = False
sync_jobs = <function sync_jobs at 0x7f5a3aadf380>
sync_for = <function sync_for at 0x7f5a3aaf4180>
sync_customizations = <function sync_customizations at 0x7f5a3bf2a0c0>
sync_fixtures = <function sync_fixtures at 0x7f5a3aaf44a0>
app_hooks = {'accounting_dimension_doctypes': ['Expense Claim', 'Expense Claim Detail', 'Expense Taxes and Charges', 'Payroll Entry'], 'advance_payment_doctypes': ['Gratuity', 'Employee Advance'], 'after_app_install': ['hrms.setup.after_app_install'], 'after_install': ['hrms.install.after_install'], 'after_migrate': ['hrms.setup.update_select_perm_after_install'], 'app_description': ['Modern HR and Payroll Software'], 'app_email': ['contact@frappe.io'], 'app_include_css': ['hrms.bundle.css'], 'app_include_js': ['hrms.bundle.js'], 'app_license': ['GNU General Public License (v3)'], 'app_name': ['hrms'], 'app_publisher': ['Frappe Technologies Pvt. Ltd.'], 'app_title': ['Frappe HR'], 'bank_reconciliation_doctypes': ['Expense Claim'], 'before_app_uninstall': ['hrms.setup.before_app_uninstall'], 'before_tests': ['hrms.tests.test_utils.before_tests'], 'before_uninstall': ['hrms.uninstall.before_uninstall'], 'calendars': ['Leave Application'], 'doc_events': {'User': {'validate': ['erpnext.setup.doctype.e...
installed_apps = ['frappe', 'erpnext', 'payments']
app = 'frappe/erpnext'
required_app = 'erpnext'
after_install = 'hrms.install.after_install'
File "apps/hrms/hrms/install.py", line 21, in after_install
raise e
BUG_REPORT_URL = 'https://github.com/frappe/hrms/issues/new'
File "apps/hrms/hrms/install.py", line 9, in after_install
setup()
BUG_REPORT_URL = 'https://github.com/frappe/hrms/issues/new'
File "apps/hrms/hrms/setup.py", line 15, in after_install
create_custom_fields(get_custom_fields())
File "apps/frappe/frappe/custom/doctype/custom_field/custom_field.py", line 326, in create_custom_fields
create_custom_field(doctype, df, ignore_validate=ignore_validate)
custom_fields = {'Employee': [{'fieldname': 'employment_type', 'fieldtype': 'Link', 'ignore_user_permissions': 1, 'label': 'Employment Type', 'oldfieldname': 'employment_type', 'oldfieldtype': 'Link', 'options': 'Employment Type', 'insert_after': 'department'}, {'fieldname': 'job_applicant', 'fieldtype': 'Link', 'label': 'Job Applicant', 'options': 'Job Applicant', 'insert_after': 'employment_details'}, {'fieldname': 'grade', 'fieldtype': 'Link', 'label': 'Grade', 'options': 'Employee Grade', 'insert_after': 'branch'}, {'fieldname': 'default_shift', 'fieldtype': 'Link', 'label': 'Default Shift', 'options': 'Shift Type', 'insert_after': 'holiday_list'}, {'collapsible': 1, 'fieldname': 'health_insurance_section', 'fieldtype': 'Section Break', 'label': 'Health Insurance', 'insert_after': 'health_details'}, {'fieldname': 'health_insurance_provider', 'fieldtype': 'Link', 'label': 'Health Insurance Provider', 'options': 'Employee Health Insurance', 'insert_after': 'health_insurance_section'}, {'depends_on':...
ignore_validate = False
update = True
doctypes_to_update = {'Employee'}
doctypes = ('Employee',)
fields = [{'fieldname': 'employment_type', 'fieldtype': 'Link', 'ignore_user_permissions': 1, 'label': 'Employment Type', 'oldfieldname': 'employment_type', 'oldfieldtype': 'Link', 'options': 'Employment Type', 'insert_after': 'department'}, {'fieldname': 'job_applicant', 'fieldtype': 'Link', 'label': 'Job Applicant', 'options': 'Job Applicant', 'insert_after': 'employment_details'}, {'fieldname': 'grade', 'fieldtype': 'Link', 'label': 'Grade', 'options': 'Employee Grade', 'insert_after': 'branch'}, {'fieldname': 'default_shift', 'fieldtype': 'Link', 'label': 'Default Shift', 'options': 'Shift Type', 'insert_after': 'holiday_list'}, {'collapsible': 1, 'fieldname': 'health_insurance_section', 'fieldtype': 'Section Break', 'label': 'Health Insurance', 'insert_after': 'health_details'}, {'fieldname': 'health_insurance_provider', 'fieldtype': 'Link', 'label': 'Health Insurance Provider', 'options': 'Employee Health Insurance', 'insert_after': 'health_insurance_section'}, {'depends_on': 'eval:doc.he...
doctype = 'Employee'
df = {'fieldname': 'employment_type', 'fieldtype': 'Link', 'ignore_user_permissions': 1, 'label': 'Employment Type', 'oldfieldname': 'employment_type', 'oldfieldtype': 'Link', 'options': 'Employment Type', 'insert_after': 'department', 'owner': 'Administrator'}
field = None
File "apps/frappe/frappe/custom/doctype/custom_field/custom_field.py", line 292, in create_custom_field
custom_field.insert()
doctype = 'Employee'
df = {'fieldname': 'employment_type', 'fieldtype': 'Link', 'ignore_user_permissions': 1, 'label': 'Employment Type', 'oldfieldname': 'employment_type', 'oldfieldtype': 'Link', 'options': 'Employment Type', 'insert_after': 'department', 'owner': 'Administrator'}
ignore_validate = False
is_system_generated = True
custom_field = <CustomField: Employee-employment_type>
File "apps/frappe/frappe/model/document.py", line 310, in insert
self.run_post_save_methods()
self = <CustomField: Employee-employment_type>
ignore_permissions = None
ignore_links = None
ignore_if_duplicate = False
ignore_mandatory = None
set_name = None
set_child_names = True
File "apps/frappe/frappe/model/document.py", line 1121, in run_post_save_methods
self.run_method("on_update")
self = <CustomField: Employee-employment_type>
File "apps/frappe/frappe/model/document.py", line 953, in run_method
out = Document.hook(fn)(self, *args, **kwargs)
self = <CustomField: Employee-employment_type>
method = 'on_update'
args = ()
kwargs = {}
fn = <function Document.run_method..fn at 0x7f5a38b0e700>
File "apps/frappe/frappe/model/document.py", line 1319, in composer
return composed(self, method, args, **kwargs)
self = <CustomField: Employee-employment_type>
args = ()
kwargs = {}
hooks = [<function clear_doctype_notifications at 0x7f5a38eaf6a0>, <function process_workflow_actions at 0x7f5a38eb1620>, <function attach_files_to_document at 0x7f5a3aa76480>, <function apply at 0x7f5a38ec8040>, <function update_due_date at 0x7f5a38ec80e0>, <function apply_permissions_for_non_standard_user_type at 0x7f5a38ec9800>]
method = 'on_update'
doc_events = {'': {'on_update': ['frappe.desk.notifications.clear_doctype_notifications', 'frappe.workflow.doctype.workflow_action.workflow_action.process_workflow_actions', 'frappe.core.doctype.file.utils.attach_files_to_document', 'frappe.automation.doctype.assignment_rule.assignment_rule.apply', 'frappe.automation.doctype.assignment_rule.assignment_rule.update_due_date', 'frappe.core.doctype.user_type.user_type.apply_permissions_for_non_standard_user_type'], 'after_rename': ['frappe.desk.notifications.clear_doctype_notifications'], 'on_cancel': ['frappe.desk.notifications.clear_doctype_notifications', 'frappe.workflow.doctype.workflow_action.workflow_action.process_workflow_actions', 'frappe.automation.doctype.assignment_rule.assignment_rule.apply'], 'on_trash': ['frappe.desk.notifications.clear_doctype_notifications', 'frappe.workflow.doctype.workflow_action.workflow_action.process_workflow_actions'], 'on_update_after_submit': ['frappe.workflow.doctype.workflow_action.workflow_action.process_w...
handler = 'frappe.core.doctype.user_type.user_type.apply_permissions_for_non_standard_user_type'
composed = <function Document.hook..compose..runner at 0x7f5a38b0eac0>
compose = <function Document.hook..compose at 0x7f5a38b0e480>
f = <function Document.run_method..fn at 0x7f5a38b0e700>
File "apps/frappe/frappe/model/document.py", line 1301, in runner
add_to_return_value(self, fn(self, *args, **kwargs))
self = <CustomField: Employee-employment_type>
method = 'on_update'
args = ()
kwargs = {}
add_to_return_value = <function Document.hook..add_to_return_value at 0x7f5a38b0e7a0>
fn = <function Document.run_method..fn at 0x7f5a38b0e700>
hooks = (<function clear_doctype_notifications at 0x7f5a38eaf6a0>, <function process_workflow_actions at 0x7f5a38eb1620>, <function attach_files_to_document at 0x7f5a3aa76480>, <function apply at 0x7f5a38ec8040>, <function update_due_date at 0x7f5a38ec80e0>, <function apply_permissions_for_non_standard_user_type at 0x7f5a38ec9800>)
File "apps/frappe/frappe/model/document.py", line 950, in fn
return method_object(*args, **kwargs)
self = <CustomField: Employee-employment_type>
args = ()
kwargs = {}
method_object = <bound method CustomField.on_update of <CustomField: Employee-employment_type>>
method = 'on_update'
File "apps/frappe/frappe/custom/doctype/custom_field/custom_field.py", line 204, in on_update
validate_fields_for_doctype(self.dt)
self = <CustomField: Employee-employment_type>
validate_fields_for_doctype = <function validate_fields_for_doctype at 0x7f5a38e2a7a0>
File "apps/frappe/frappe/core/doctype/doctype/doctype.py", line 1181, in validate_fields_for_doctype
validate_fields(meta)
doctype = 'Employee'
meta = <Meta: Employee>
File "apps/frappe/frappe/core/doctype/doctype/doctype.py", line 1619, in validate_fields
check_link_table_options(meta.get("name"), d)
meta = <Meta: Employee>
check_illegal_characters = <function validate_fields..check_illegal_characters at 0x7f5a38b93100>
check_invalid_fieldnames = <function validate_fields..check_invalid_fieldnames at 0x7f5a38b92340>
check_unique_fieldname = <function validate_fields..check_unique_fieldname at 0x7f5a38b92700>
check_fieldname_length = <function validate_fields..check_fieldname_length at 0x7f5a38b34f40>
check_illegal_mandatory = <function validate_fields..check_illegal_mandatory at 0x7f5a38b34680>
check_link_table_options = <function validate_fields..check_link_table_options at 0x7f5a38b34cc0>
check_hidden_and_mandatory = <function validate_fields..check_hidden_and_mandatory at 0x7f5a38b34d60>
check_width = <function validate_fields..check_width at 0x7f5a38b34c20>
check_in_list_view = <function validate_fields..check_in_list_view at 0x7f5a38b34b80>
check_in_global_search = <function validate_fields..check_in_global_search at 0x7f5a38b34ea0>
check_dynamic_link_options = <function validate_fields..check_dynamic_link_options at 0x7f5a38b34ae0>
check_illegal_default = <function validate_fields..check_illegal_default at 0x7f5a38b34e00>
check_precision = <function validate_fields..check_precision at 0x7f5a38b34fe0>
check_unique_and_text = <function validate_fields..check_unique_and_text at 0x7f5a38b35080>
check_fold = <function validate_fields..check_fold at 0x7f5a38b35120>
check_search_fields = <function validate_fields..check_search_fields at 0x7f5a38b351c0>
check_title_field = <function validate_fields..check_title_field at 0x7f5a38b35260>
check_image_field = <function validate_fields..check_image_field at 0x7f5a38b35300>
check_is_published_field = <function validate_fields..check_is_published_field at 0x7f5a38b353a0>
check_website_search_field = <function validate_fields..check_website_search_field at 0x7f5a38b35440>
check_timeline_field = <function validate_fields..check_timeline_field at 0x7f5a38b354e0>
check_sort_field = <function validate_fields..check_sort_field at 0x7f5a38b35580>
check_illegal_depends_on_conditions = <function validate_fields..check_illegal_depends_on_conditions at 0x7f5a38b35620>
check_table_multiselect_option = <function validate_fields..check_table_multiselect_option at 0x7f5a38b356c0>
scrub_options_in_select = <function validate_fields..scrub_options_in_select at 0x7f5a38b35760>
scrub_fetch_from = <function validate_fields..scrub_fetch_from at 0x7f5a38b35800>
validate_data_field_type = <function validate_fields..validate_data_field_type at 0x7f5a38b358a0>
check_child_table_option = <function validate_fields..check_child_table_option at 0x7f5a38b35940>
check_max_height = <function validate_fields..check_max_height at 0x7f5a38b359e0>
check_no_of_ratings = <function validate_fields..check_no_of_ratings at 0x7f5a38b35a80>
d = <LinkDocField: employment_type parent=Employee>
fieldname_list = ['basic_details_tab', 'basic_information', 'employee', 'naming_series', 'first_name', 'middle_name', 'last_name', 'employee_name', 'column_break_9', 'gender', 'date_of_birth', 'salutation', 'column_break1', 'date_of_joining', 'image', 'status', 'erpnext_user', 'user_id', 'create_user', 'create_user_permission', 'company_details_section', 'company', 'department', 'employment_type', 'employee_number', 'column_break_25', 'designation', 'reports_to', 'column_break_18', 'branch', 'employment_details', 'scheduled_confirmation_date', 'column_break_32', 'final_confirmation_date', 'contract_end_date', 'col_break_22', 'notice_number_of_days', 'date_of_retirement', 'contact_details', 'cell_number', 'column_break_40', 'personal_email', 'company_email', 'column_break4', 'prefered_contact_email', 'prefered_email', 'unsubscribed', 'address_section', 'current_address', 'current_accommodation_type', 'column_break_46', 'permanent_address', 'permanent_accommodation_type', 'emergency_contact_details', 'pe...
fields = [,

, <DataDocField: employee parent=Employee>, <SelectDocField: naming_series parent=Employee>, <DataDocField: first_name parent=Employee>, <DataDocField: middle_name parent=Employee>, <DataDocField: last_name parent=Employee>, <DataDocField: employee_name parent=Employee>, , <LinkDocField: gender parent=Employee>, <DateDocField: date_of_birth parent=Employee>, <LinkDocField: salutation parent=Employee>, , <DateDocField: date_of_joining parent=Employee>, , <SelectDocField: status parent=Employee>,

, <LinkDocField: user_id parent=Employee>, <ButtonDocField: create_user parent=Employee>, <CheckDocField: create_user_permission parent=Employee>, <Section BreakDocField: company_d...
not_allowed_in_list_view = ['Section Break', 'Column Break', 'Tab Break', 'HTML', 'Table', 'Table MultiSelect', 'Button', 'Image', 'Fold', 'Heading', 'Attach Image']
File "apps/frappe/frappe/core/doctype/doctype/doctype.py", line 1256, in check_link_table_options
frappe.throw(
docname = 'Employee'
d = <LinkDocField: employment_type parent=Employee>
options = None
File "apps/frappe/frappe/init.py", line 577, in throw
msgprint(
msg = 'Employee: Options must be a valid DocType for field Employment Type in row 24'
exc = <class 'frappe.core.doctype.doctype.doctype.WrongOptionsDoctypeLinkError'>
title = None
is_minimizable = False
wide = False
as_list = False
File "apps/frappe/frappe/init.py", line 549, in msgprint
_raise_exception()
msg = 'Employee: Options must be a valid DocType for field Employment Type in row 24'
title = None
raise_exception = <class 'frappe.core.doctype.doctype.doctype.WrongOptionsDoctypeLinkError'>
as_table = False
as_list = False
indicator = 'red'
alert = False
primary_action = None
is_minimizable = False
wide = False
realtime = False
sys = <module 'sys' (built-in)>
_raise_exception = <function msgprint.._raise_exception at 0x7f5a38b35b20>
_strip_html_tags = <functools._lru_cache_wrapper object at 0x7f5a38be90c0>
inspect = <module 'inspect' from '/usr/lib/python3.11/inspect.py'>
out = {'message': 'Employee: Options must be a valid DocType for field Employment Type in row 24', 'title': 'Message', 'indicator': 'red', 'raise_exception': 1, '__frappe_exc_id': '17fc4ed9b7cceb51968c81995050401dcbb7ae3fad7a0ad9d6104842'}
strip_html_tags = <function strip_html_tags at 0x7f5a3cc3d300>
File "apps/frappe/frappe/init.py", line 500, in _raise_exception
raise exc
exc = WrongOptionsDoctypeLinkError('Employee: Options must be a valid DocType for field Employment Type in row 24')
inspect = <module 'inspect' from '/usr/lib/python3.11/inspect.py'>
msg = 'Employee: Options must be a valid DocType for field Employment Type in row 24'
out = {'message': 'Employee: Options must be a valid DocType for field Employment Type in row 24', 'title': 'Message', 'indicator': 'red', 'raise_exception': 1, '__frappe_exc_id': '17fc4ed9b7cceb51968c81995050401dcbb7ae3fad7a0ad9d6104842'}
raise_exception = <class 'frappe.core.doctype.doctype.doctype.WrongOptionsDoctypeLinkError'>
frappe.core.doctype.doctype.doctype.WrongOptionsDoctypeLinkError: Employee: Options must be a valid DocType for field Employment Type in row 24

[sgr-patel]

any solutions yet ? the main site shows internal server error after encountering above problem

[dkoryto]

The latest branch works on version 16-dev, try switching to 15.
cd apps/hrms
git fetch upstream version-15:version-15
git checkout version-15
cd ../..
and
bench --site [sitename] migrate

[hiteshprajapati]

As @ruchamahabal suggested here - first we need to start the bench and then do the installation of HRMS.. it works for me
#1334 (comment)

Also I am running all on version 15

[ruchamahabal]

#1459
#1460

Pinned dependencies will now validate version mismatch on Frappe Cloud. Closing the same