fix: Roster path in Shift & Attendance workspace #2887
Conversation
Fix relative URL to work behind a proxy
ruchamahabal
left a comment
ruchamahabal
left a comment
There was a problem hiding this comment.
Can you add a before after screenshot/gif for showing the problem?
|
I suspect the issue lies with the functions frappe.utils.generate_route or get_route. When operating behind a proxy, shortcut URLs that end with a trailing slash (/) are not correctly converted into fully qualified URLs. If the trailing slash is omitted, the URL is properly interpreted as a relative path. Change: After: |
ruchamahabal
changed the title
| "label": "Roster", | ||
| "type": "URL", | ||
| "url": "/hr/roster/" | ||
| "url": "/hr/roster" |
There was a problem hiding this comment.
You will also have to update modified timestamp for this json document for it to get synced on migrating sites
Also requesting you to move description to the main PR description section from the comment
And for future contributions please follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/
There was a problem hiding this comment.
I guess thats fine now?
update modified-date
(cherry picked from commit 1283c62) # Conflicts: # hrms/hr/workspace/shift_&_attendance/shift_&_attendance.json
) * Merge pull request #2887 from seclution/patch-1 (cherry picked from commit 1283c62) # Conflicts: # hrms/hr/workspace/shift_&_attendance/shift_&_attendance.json * chore: fix conflicts * chore: fix conflicts --------- Co-authored-by: Kai Biebel <38378574+seclution@users.noreply.github.com> Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
## [15.43.1](v15.43.0...v15.43.1) (2025-04-16) ### Bug Fixes * **LA:** Show alert with newly changed value ([c5e7470](c5e7470)) * **leave-application:** Format date string based on user locale ([1bf72d1](1bf72d1)) * **payroll bank entry:** ignore employee with zero payment amount ([564d378](564d378)) * precision error for outstanding amount calculation in expense claim ([5f053e0](5f053e0)) * Roster path in Shift & Attendance workspace (backport [#2887](#2887)) ([#2973](#2973)) ([56c778b](56c778b)) * Set from_date or to_date automatically and show alert ([12b2de0](12b2de0))
2 participants
Fix relative URL to work behind a proxy
I suspect the issue lies with the functions frappe.utils.generate_route or get_route. When operating behind a proxy, shortcut URLs that end with a trailing slash (/) are not correctly converted into fully qualified URLs. If the trailing slash is omitted, the URL is properly interpreted as a relative path.
Before:
Change:
After:
