Skip to content

fix(expense_claim): handle partial advance settlement in expense claims (backport #4563)#4591

Merged
iamkhanraheel merged 2 commits into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-4563
May 26, 2026
Merged

fix(expense_claim): handle partial advance settlement in expense claims (backport #4563)#4591
iamkhanraheel merged 2 commits into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-4563

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented May 26, 2026

Reason

  • Expense Claims created from Employee Advance were incorrectly marked as "Paid" even when the advance amount only partially covered the claimed amount. As a result outstanding payable amount was ignored and payment action was not available
claimReimburseBug.mov

Changes Done

  • Expense Claims with partial Employee Advance coverage are now correctly marked as “Unpaid” instead of “Paid”, ensuring any remaining balance is available for reimbursement flow.
claimReimburseFix.mov

Summary by CodeRabbit

  • Bug Fixes

    • Expense claim status logic corrected so claims with advances aren’t prematurely marked as paid when advances remain unsettled.
  • Tests

    • Updated expense claim tests to cover advance-linked scenarios and verify is_paid behavior before and after submission.

Review Change Stack


This is an automatic backport of pull request #4563 done by [Mergify](https://mergify.com).

@mergify mergify Bot requested review from asmitahase and ruchamahabal as code owners May 26, 2026 05:16
@iamkhanraheel iamkhanraheel merged commit 96bf118 into version-16-hotfix May 26, 2026
11 checks passed
@iamkhanraheel iamkhanraheel deleted the mergify/bp/version-16-hotfix/pr-4563 branch May 26, 2026 06:18
@frappe-pr-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants