App validation

[Aradhya-Tripathi]

App Validations [Pre-Install]

• Ensure internal and external imports are accounted for.

  • Internal imports are app imports like pilot.core.bench import Bench
  • External imports are handled by the pyproject.toml declarations of app + framework itself.
  • Optional imports are not hard failures

    try:
         import something
    except ModuleNotFound:
         pass
    except ImportError:
         pass    

• Ensure the directory structure for frappe apps is sound

• Ensure get-app fails when imports are broken.

Since app validations are pre-install therefore we can't fallback to a simpler run files with import check, since the env won't have those dependencies yet since the app is not installed.

[greptile-apps]

Confidence Score: 5/5

Safe to merge; static analysis correctly guards each failure mode and the rollback path works for the common case.

All previously flagged correctness issues are fixed. Remaining observations are efficiency and defensive-cleanup concerns that don't affect correctness on the happy or failure path.

pilot/core/app_validator.py — double _all_imports() call; pilot/commands/get_app.py — narrow except clause in _validate.

_{Reviews (6): Last reviewed commit: "fix: Integration tests failing due to in..." | Re-trigger Greptile}