feat: default a new bench to lite mode - #415
Merged
Merged
Conversation
BenchCreator now writes `[lite_mode] enabled = true`, so a fresh bench runs one process for web, realtime and jobs instead of the web + socketio + worker set. `lite_mode_enabled` joins FLAT_KEYS so creation sets it through the same flat-settings path as admin_tls and db_type. LiteModeConfig.enabled still defaults to False in the dataclass. A bench.toml written before this change carries no [lite_mode] table and keeps its current process set, so no running bench changes topology on upgrade. Opting out stays the Settings toggle, which writes `enabled = false` and queues switch-lite-mode. A new bench on a frappe without frappe/runner.py still falls back to the ordinary set through Bench.is_lite_mode.
Contributor
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (3): Last reviewed commit: "Merge branch 'develop' into lite_mode_De..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BenchCreatorwrites[lite_mode] enabled = true, so a fresh bench runs one process for web, realtime and jobs instead of the web + socketio + worker set.lite_mode_enabledjoinsFLAT_KEYSso creation sets it through the same flat-settings path asadmin_tlsanddb_type.LiteModeConfig.enabledstill defaults toFalsein the dataclass, so abench.tomlwritten before this change carries no[lite_mode]table and keeps its current process set — no running bench changes topology on upgrade. Opting out stays the Settings toggle.A new bench on a frappe without
frappe/runner.pystill falls back to the ordinary set throughBench.is_lite_mode.