fix(api): Tighten site backup link validation (backport #6085)#6160
Merged
fix(api): Tighten site backup link validation (backport #6085)#6160
Conversation
- align `get_backup_link` with the existing site-level backup download behavior - tighten validation around backup link resolution and accepted file types - add regression coverage for mismatched backup/site lookups and invalid file selections (cherry picked from commit 56f3535)
(cherry picked from commit 4971ef9)
Tests reuse deterministic site names across rollbacks, which can leave stale Site values in Frappe's per-request cache. Child docs created during after_insert (Site Activity, Site Domain) then resolve the old team via fetch_from, causing LinkValidationError. (cherry picked from commit 0fb19ef)
mergify
Bot
requested review from
balamurali27,
ssiyad and
tanmoysrt
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6160 +/- ##
==========================================
+ Coverage 51.66% 51.68% +0.02%
==========================================
Files 905 905
Lines 75195 75222 +27
Branches 272 272
==========================================
+ Hits 38847 38881 +34
+ Misses 36325 36318 -7
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ssiyad
approved these changes
Apr 22, 2026
Collaborator
|
🎉 This PR is included in version 0.16.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_backup_linkwith the existing site-level backup download behaviorThis is an automatic backport of pull request #6085 done by [Mergify](https://mergify.com).