fix: newlines do not work in block quotes - #853
Merged
Conversation
nikkothari22
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: newlines do not work in block quotes
Problem:
CustomBlockQuote Renderer was containing the textContent of the incoming node directly inside Blockquote, hence a single line was getting displayed.
Solution:
Removed CustomBlockQuote renderers in both mobile and web.
web : Applied styles for tiptap-renderer directly on blockquote through css (default option enabled in TipTap renderer)
mobile : Applied tailwind css classes inside blockquote's HTML Attributes in useEditor.
This PR closes #844 and #623.