feat: Editing nested fragments (dialogs inside dialog, dialogs inside studio component) - #223
Merged
Merged
Conversation
… panel + in Component Editor layer
…r main canvas - useful for dialogs inside dialog, dialogs inside studio components
Contributor
Confidence Score: 4/5The PR is not yet safe to merge because a pending save can still close or clean the wrong fragment after concurrent navigation. Fragment identity is not captured before awaiting the save, while breadcrumb and nested-editor actions can mutate the stack during that wait. Files Needing Attention: frontend/src/pages/StudioPage.vue Reviews (12): Last reviewed commit: "fix: props panel no longer writes compon..." | Re-trigger Greptile |
- they should be edited by going to the studio component definition
…shown on the page
…fragment root width
…sn't re-marked dirty
…n selection - this was marking canvas dirty on some block selection that didn't change, prop editor panel was setting default on the component block directly. Component already applies its own defaults at render time, so just show them in props panel, don't directly apply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nested-overlays.mp4
To edit a studio component, you had to right-click> Edit Component. Now there are more shortcuts for this action
Fixes:
pass a block copy to fragment save actions so a saved fragment isn't re-marked dirty
props panel no longer writes component defaults into the block on selection
this was marking canvas dirty on some block selection that didn't change, prop editor panel was setting default on the component block directly. Component already applies its own defaults at render time, so just show them in props panel, don't directly apply