Skip to content

feat: capture build failure error and show in a dialog - #252

Merged
ruchamahabal merged 2 commits into
frappe:developfrom
ruchamahabal:fix-build-config
Aug 19, 2026
Merged

feat: capture build failure error and show in a dialog#252
ruchamahabal merged 2 commits into
frappe:developfrom
ruchamahabal:fix-build-config

Conversation

@ruchamahabal

@ruchamahabal ruchamahabal commented Aug 19, 2026

Copy link
Copy Markdown
Member

So that such errors don't go unnoticed: #251

image image

@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The previously reported silent-success path is fixed because queued builds now invoke a method that preserves raised build failures.

Reviews (3): Last reviewed commit: "feat: show warning dialog with link to f..." | Re-trigger Greptile

Comment thread studio/studio/doctype/studio_app/studio_app.py
@ruchamahabal
ruchamahabal merged commit fbaaf6c into frappe:develop Aug 19, 2026
2 checks passed
@ruchamahabal ruchamahabal changed the title feat: capture build failure error and show in toast feat: capture build failure error and show in a dialog Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant