Remove the eight tools cut in the account-free pivot - #159
Merged
Conversation
Toolbox becomes a free public website with no accounts. Five of these tools stored personal records for a signed-in owner, so without accounts none of them can work: Expenses, Library, Reminders, Checklists and Notes. Tone Generator, Metronome and Audio Inspector go with them to keep the tool list focused. All three run fully in the browser and are the cheapest on the list to restore. The registry drops from 23 tools to 15. The Productivity and Money categories had no tools left, so they go too. The migration patch drops 15 DocTypes. `frappe.delete_doc` removes a DocType definition but keeps its table: `frappe/model/delete_doc.py` only ever drops one in developer mode outside a migration, and a patch always runs inside one. The first run of this patch left all 15 tables behind with their rows intact, so the patch drops each table explicitly. It is idempotent, and was verified by running it twice on both sites. `hooks.py` loses the reminders cron, the permission handlers for every removed DocType, and an `after_migrate` entry that called a deleted function. That last one would have broken `bench migrate` outright. OTHER_IDEAS.md is new. It records every removal with its reason, together with the ideas dropped earlier — the ffmpeg converter, speech to text, the shared expense and password vault ideas, and the Frappe Suite merge. Read it before proposing a feature. CLAUDE.md carried three stale claims that this work disproved: that the production datasets were not active, that Weather and Dictionary were placeholders, and a tool list naming four removed tools. All four datasets are Active at production scale. Both tools are complete. vitest 594 green, backend 59 green, build clean, full e2e matrix 172 passed. Closes #158 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158
Toolbox becomes a free public website with no accounts. Eight tools leave the product.
What goes
Needed an account, so cannot work: Expenses, Library, Reminders, Checklists, Notes.
Removed to keep the list focused: Tone Generator, Metronome, Audio Inspector.
The registry drops from 23 tools to 15. The Productivity and Money categories had no tools left, so they go too.
The patch that matters
frappe.delete_docremoves a DocType definition but keeps its table.frappe/model/delete_doc.pyonly ever drops one in developer mode outside a migration, and a patch always runs inside one.The first run of this patch left all 15 tables behind with their rows intact. The patch now drops each table explicitly. It is idempotent, and was verified by running it twice on both
toolbox.localhostandtoolbox-test.localhost.Two things this found
hooks.pyhad anafter_migrateentry callinginstall_default_checklist_templates. Deleting the module without removing the hook would have brokenbench migrateoutright.CLAUDE.mdcarried three stale claims that this work disproved: that the production datasets were not active, that Weather and Dictionary were placeholders, and a tool list naming four removed tools. All four datasets are Active at production scale — PIN 165,616 rows, IFSC 181,719, HSN 18,687, Dictionary 147,982. Both tools are complete.New file
OTHER_IDEAS.mdrecords every removal with its reason, together with the ideas dropped earlier: the ffmpeg converter, speech to text, the shared expense and password vault ideas, and the Frappe Suite merge. Read it before proposing a feature.Verification
DocFieldorDocPermrows left behindToolbox Audio AssetandToolbox User Preferencego in their own issues.Out of scope
Audio Recorder still stores recordings on the server, and the authentication layer is still in place. Both change next.