feat: support custom favicons for each wiki space - #413
Conversation
| "url": "/drafts", | ||
| }, | ||
| ], | ||
| "favicon": wiki_space.favicon, |
There was a problem hiding this comment.
What if favicon is not set?
There was a problem hiding this comment.
Updated code to set a default favicon when none is specified
|
@vishwajeet-13 please use semantic commits for all your commit messages. |
| "url": "/drafts", | ||
| }, | ||
| ], | ||
| "favicon": wiki_space.favicon or "/assets/frappe/images/frappe-favicon.svg", |
There was a problem hiding this comment.
Better way would be to only add favicon to the context if there is a favicon in wiki space, else let the base be used (if we don't add to context). Because we want the app's/website settings favicon to take over and not a hardcoded one like in this case.
|
Let's also move the two attach images to the next column and the following child table to a next section? |
| "url": "/drafts", | ||
| }, | ||
| ], | ||
|
|
|
Also, can you share an screenshot of the updated form layout? |
15a7dad to
e016ccb
Compare
e016ccb to
c3a0cd3
Compare
|
Screenshot of new image is attached below & also removed extra space. 
|
2 participants
Previously, the favicon remained the same when switching between different Wiki Spaces, which caused confusion and inconsistency in branding across spaces.
This PR fixes that by adding a favicon field to the Wiki Space DocType, allowing each space to have its own unique favicon.
Now, when you switch between Wiki Spaces, the favicon updates accordingly — improving clarity and user experience.
Before -
After -
WhatsApp.Video.2025-07-29.at.9.15.43.PM.mp4
closes #405