fix: keep the space logo picker inside the viewport - #774
Merged
Conversation
 |
gajjug004
force-pushed
the
fix/space-logo-picker-popover-overflow
branch
from
September 11, 2026 04:22
e871ca4 to
40f771f
Compare
Member
|
Let's remove the test, not needed. |
The picker's trigger sits low in the space settings dialog, so the popover flips above it. reka defaults to sticky: "partial", which passes limitShift() to shift() -- the panel stays glued to its trigger instead of clamping to the viewport, so a panel taller than the room on that side runs off the top of the screen. The colour swatches and the Icon/Upload tabs were unreachable. Cap both icon popovers at --reka-popper-available-height and let the icon grid shrink into what is left: the scroller is a flex child of the grid rather than a percentage height, which a flex item's auto height leaves indefinite -- it kept its full 18rem, spilled past the panel and was chopped mid-row by the shell's overflow. IconPicker's tab-icon popover had the same bug.
gajjug004
force-pushed
the
fix/space-logo-picker-popover-overflow
branch
from
September 11, 2026 06:29
40f771f to
c2bd670
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening the Space Logo picker on a short window pushes the popover off the top of the screen. The colour swatches and the Icon/Upload tabs cannot be reached.
Before
After
Solution
reka's popover defaults to
sticky: "partial", soshift()getslimitShift()and keeps the panel attached to its trigger rather than clamping it to the viewport. A panel taller than the room on its side has to cap itself.Both icon popovers now cap at
--reka-popper-available-height, and the icon grid shrinks into what is left: its scroller is a flex child rather than a percentage height, which a flex item's auto height leaves indefinite. Without that the grid kept its full 18rem, spilled past the panel and was chopped mid-row by the shell's overflow, taking the bottom padding and the fade with it.IconPicker's tab-icon popover had the same bug and got the same fix.