Skip to content

Adding a second solution with a "for" loop#35299

Merged
thecodingaviator merged 8 commits into
freeCodeCamp:masterfrom
codingk8:patch-1
Mar 28, 2019
Merged

Adding a second solution with a "for" loop#35299
thecodingaviator merged 8 commits into
freeCodeCamp:masterfrom
codingk8:patch-1

Conversation

@codingk8
Copy link
Copy Markdown
Contributor

  • adapted some texts to make the whole thing coherent
  • added some Useful links at the end of the article
  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

+ adapted some texts to make the whole thing coherent
+ added some Useful links at the end of the article
@codingk8
Copy link
Copy Markdown
Contributor Author

Please let me know if I could have improved something in this PR.

Copy link
Copy Markdown
Contributor

@thecodingaviator thecodingaviator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and make the required changes

@codingk8
Copy link
Copy Markdown
Contributor Author

All done I guess. Thanks!

@thecodingaviator
Copy link
Copy Markdown
Contributor

I had used backticks for marking code, which you've changed to ", please set it back to `

@codingk8
Copy link
Copy Markdown
Contributor Author

Right, sorry about that. Should be OK now. Thank!

@codingk8
Copy link
Copy Markdown
Contributor Author

codingk8 commented Mar 1, 2019

Sorry to bother you. It's been 10 days and it's still open. Is there a pb? Is it normal ? Thanks for letting me know 😃

@thecodingaviator
Copy link
Copy Markdown
Contributor

Yup, such waiting times are normal since we are still dealing with a lot of Pull Requests from October last year. We're hierarchically going through the PRs from oldest to latest

@codingk8
Copy link
Copy Markdown
Contributor Author

codingk8 commented Mar 1, 2019

OK fine. It's good to know. So I just wait until it's merged.

@RandellDawson
Copy link
Copy Markdown
Member

@codingk8 There is only one PR ahead of yours in terms of the file you changed, but it affects many other files. This means, we are having to review many other earlier PRs (about 20) which affect files on the other PR first. Probably 1-2 weeks out is my guess.

@thecodingaviator
Copy link
Copy Markdown
Contributor

@RandellDawson Do we want the solutions to be named solution 1 and solution 2 or just solutions or intermediate and advanced, like how we have it in the other JS challenges

@RandellDawson
Copy link
Copy Markdown
Member

@thecodingaviator Personally, it does not matter since we have no true policy in the docs about this. As you know, issue #35453 hopes to standardize and create a formal policy around these types of articles.

Copy link
Copy Markdown
Contributor

@thecodingaviator thecodingaviator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@thecodingaviator
Copy link
Copy Markdown
Contributor

Thanks for contributing to the freeCodeCamp repository. Congratulations on your first PR! 🎊

Look forward to more contributions from you! ✈️

@thecodingaviator thecodingaviator merged commit 1df0fcd into freeCodeCamp:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants