Skip to content

fix: install cross-env for server npm script#36855

Merged
raisedadead merged 1 commit intomasterfrom
fix/docker-cross-env
Sep 26, 2019
Merged

fix: install cross-env for server npm script#36855
raisedadead merged 1 commit intomasterfrom
fix/docker-cross-env

Conversation

@ojeytonwilliams
Copy link
Copy Markdown
Contributor

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

I don't think this was ever reported as an issue, but it appeared on the forum https://www.freecodecamp.org/forum/t/cross-env-not-found/308753/2 and @RandellDawson noticed it.

The problem is simply that npm run, unlike require, does not search the parent directories. This affects docker, because it calls npm run develop from the api-server directory.

@ojeytonwilliams ojeytonwilliams requested a review from a team September 26, 2019 13:32
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 26, 2019

@raisedadead raisedadead merged commit 32ee2f0 into master Sep 26, 2019
@raisedadead raisedadead deleted the fix/docker-cross-env branch September 26, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants