fix(e2e): wait for next challenge render#41888
Merged
raisedadead merged 4 commits intofreeCodeCamp:mainfrom Apr 22, 2021
Merged
fix(e2e): wait for next challenge render#41888raisedadead merged 4 commits intofreeCodeCamp:mainfrom
raisedadead merged 4 commits intofreeCodeCamp:mainfrom
Conversation
github-actions
bot
added
the
scope: tools/scripts
raisedadead
reviewed
Apr 22, 2021
Member
raisedadead
left a comment
raisedadead
left a comment
There was a problem hiding this comment.
I see the test run was cancelled. Not sure if this is ready or WIP?
Contributor
Author
|
I'm still in the dark about what's going on here. I'll give an update when I have more of a clue. |
Member
|
Yeah, I figured that you were stuck. |
Contributor
Author
|
I still don't have much of a clue what the root cause of this is. Possibly something strange with Gatsby (since it's got its own webpack config that's creating these chunks) or vercel/serve. |
Contributor
Author
|
@raisedadead I'm not 100% confident it's fixed, but it has passed the tests. |
raisedadead
approved these changes
Apr 22, 2021
raisedadead
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was caused by
cy.contains('Go to next challenge').click();and then not waiting for the result before visiting the next page.