Skip to content

Conversation

@ojeytonwilliams
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

This reverts #42103, switches to @freecodecamp/strip-comments and ignores the type issues (for now).

Closes freeCodeCamp/strip-comments#10

@ojeytonwilliams ojeytonwilliams requested review from a team and lasjorg May 26, 2021 09:28
@gitpod-io
Copy link

gitpod-io bot commented May 26, 2021

@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label May 26, 2021
@ojeytonwilliams
Copy link
Contributor Author

@moT01 I'm sure I've not broken Safari this time, but if you could give a look that would be awesome.

@lasjorg
Copy link
Contributor

lasjorg commented May 26, 2021

LGTM

But it would be nice to get a positive confirmation that nothing is broken in Safari.

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Played around with a number of different types of lessons in Safari - nothing seemed broken.

Copy link
Contributor

@lasjorg lasjorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moT01 Thanks for testing in Safari. With that LGTM.

@lasjorg lasjorg merged commit 3b115a1 into freeCodeCamp:main May 31, 2021
@ojeytonwilliams ojeytonwilliams deleted the feat/use-strip-comments branch June 1, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reminder to re-implement library

3 participants