Skip to content

feat: transfer The Odin Project to its own superblock#49202

Merged
Sembauke merged 11 commits intomainfrom
feat/the-odin-project-superblock
Feb 8, 2023
Merged

feat: transfer The Odin Project to its own superblock#49202
Sembauke merged 11 commits intomainfrom
feat/the-odin-project-superblock

Conversation

@Sembauke
Copy link
Copy Markdown
Member

@Sembauke Sembauke commented Jan 30, 2023 •
edited
Loading

Checklist:

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Jan 30, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jan 30, 2023 •
edited by ghost
Loading

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@ojeytonwilliams ojeytonwilliams mentioned this pull request Feb 1, 2023
Merged
4 tasks
@Sembauke Sembauke marked this pull request as ready for review February 2, 2023 08:23
@Sembauke Sembauke requested a review from a team February 2, 2023 08:24
@Sembauke Sembauke added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 2, 2023
@Sembauke Sembauke changed the title feat: the odin-project superblock feat: transfer The Odin Project to its own superblock Feb 2, 2023
moT01
moT01 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@moT01 moT01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @Sembauke 🎉 I left a few minor comments below.

Be sure to complete the checklist in the PR description 😉

@Sembauke
Copy link
Copy Markdown
Member Author

Sembauke commented Feb 4, 2023

Thanks @moT01 I will address those issues in this pull-request

@Sembauke Sembauke merged commit 928dcbe into main Feb 8, 2023
@Sembauke Sembauke deleted the feat/the-odin-project-superblock branch February 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moT01 moT01 moT01 approved these changes

@Nirajn2311 Nirajn2311 Nirajn2311 approved these changes

@ojeytonwilliams ojeytonwilliams Awaiting requested review from ojeytonwilliams

Assignees

No one assigned

Labels

platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sembauke @moT01 @Nirajn2311 @ojeytonwilliams