Skip to content

test(e2e,playwright): donate.tsx#51768

Merged
naomi-lgbt merged 6 commits intofreeCodeCamp:mainfrom
anand-harsh:anand-harsh-patch-1
Oct 3, 2023
Merged

test(e2e,playwright): donate.tsx#51768
naomi-lgbt merged 6 commits intofreeCodeCamp:mainfrom
anand-harsh:anand-harsh-patch-1

Conversation

@anand-harsh
Copy link
Copy Markdown
Contributor

@anand-harsh anand-harsh commented Oct 2, 2023 •
edited by naomi-lgbt
Loading

Checklist:

Related to #51705

Updated PR of PR #51723

@anand-harsh anand-harsh requested a review from a team October 2, 2023 15:43
@anand-harsh anand-harsh mentioned this pull request Oct 2, 2023
Closed
4 tasks
@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Oct 2, 2023
@ghost
Copy link
Copy Markdown

ghost commented Oct 2, 2023 •
edited by ghost
Loading

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

huyenltnguyen
huyenltnguyen reviewed Oct 3, 2023
View reviewed changes
@huyenltnguyen huyenltnguyen added the status: waiting update Is awaiting update, after feedback or request for changes label Oct 3, 2023
@anand-harsh
Copy link
Copy Markdown
Contributor Author

anand-harsh commented Oct 3, 2023

Hi @huyenltnguyen I have resolved the issues. Kindly check and suggest if any more needed. Thank you for helping me with it.

huyenltnguyen
huyenltnguyen approved these changes Oct 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anand-harsh Thank you for the PR and congratulations on your first contribution to this repo 🎉

Just a small note though, I noticed that your branch has a patch-1 part. This indicates that you were editing the files directly on GitHub, and while this is convenient, it is not a practice we recommend. Instead, you should follow our setup guide to make and test the changes locally 🙂

@huyenltnguyen huyenltnguyen added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update Is awaiting update, after feedback or request for changes labels Oct 3, 2023
@huyenltnguyen huyenltnguyen changed the title feat(e2e,playwright): created test file for donate-page-default.ts test(e2e,playwright): donate.tsx Oct 3, 2023
@anand-harsh
Copy link
Copy Markdown
Contributor Author

anand-harsh commented Oct 3, 2023 •
edited
Loading

LGTM 👍

@anand-harsh Thank you for the PR and congratulations on your first contribution to this repo 🎉

Just a small note though, I noticed that your branch has a patch-1 part. This indicates that you were editing the files directly on GitHub, and while this is convenient, it is not a practice we recommend. Instead, you should follow our setup guide to make and test the changes locally 🙂

Earlier I pushed through github in old PR but later pushed locally without changing branch name.
As you can see logs , Lint case is passed

@huyenltnguyen huyenltnguyen mentioned this pull request Oct 3, 2023
Closed
4 tasks
@naomi-lgbt naomi-lgbt merged commit 4eae603 into freeCodeCamp:main Oct 3, 2023
@naomi-lgbt
Copy link
Copy Markdown
Member

naomi-lgbt commented Oct 3, 2023

Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝

This was referenced Oct 3, 2023
Closed
Closed
@raditotev raditotev removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 11, 2023
@Sembauke Sembauke mentioned this pull request May 28, 2024
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees

No one assigned

Labels

platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anand-harsh @naomi-lgbt @huyenltnguyen @raditotev