Skip to content

feat(curriculum): add functions calculator workshop #55949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moT01 merged 8 commits into from
Aug 30, 2024
Merged

feat(curriculum): add functions calculator workshop #55949

moT01 merged 8 commits into from
Aug 30, 2024

Conversation

@jdwilkin4
Copy link
Contributor

@jdwilkin4 jdwilkin4 commented Aug 27, 2024

Checklist:

@jdwilkin4 jdwilkin4 added the full stack cert This label is for the new full stack certification label Aug 27, 2024
@jdwilkin4 jdwilkin4 self-assigned this Aug 27, 2024
@jdwilkin4 jdwilkin4 requested a review from a team August 27, 2024 17:01
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Aug 27, 2024
@jdwilkin4 jdwilkin4 requested a review from Ksound22 August 28, 2024 12:16
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 28, 2024
Sembauke
Sembauke requested changes Aug 29, 2024
View reviewed changes
@jdwilkin4 @Sembauke
Apply suggestions from code review
b3df205 
Co-authored-by: Sem Bauke <sem@freecodecamp.org>
@jdwilkin4 jdwilkin4 requested a review from Sembauke August 29, 2024 16:23
moT01
moT01 reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @jdwilkin4 🎉

Only suggestion I have would be to remove "app" from the dashed names.

@jdwilkin4
chore: rename project
4f4980c
@jdwilkin4
Merge remote-tracking branch 'refs/remotes/origin/curriculum-function…
1994a56 
…s-calculator-workshop' into curriculum-functions-calculator-workshop

resolving merge conflict
@jdwilkin4 jdwilkin4 requested a review from moT01 August 30, 2024 14:34
@moT01 moT01 merged commit 370061a into freeCodeCamp:main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moT01 moT01 moT01 approved these changes

@Sembauke Sembauke Sembauke approved these changes

@Ksound22 Ksound22 Awaiting requested review from Ksound22

Assignees

@jdwilkin4 jdwilkin4

Labels

full stack cert This label is for the new full stack certification platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdwilkin4 @moT01 @Sembauke