chore(tests): migrate shared folder to Vitests#62270
Merged
raisedadead merged 10 commits intofreeCodeCamp:mainfrom Sep 22, 2025
Merged
chore(tests): migrate shared folder to Vitests#62270raisedadead merged 10 commits intofreeCodeCamp:mainfrom
raisedadead merged 10 commits intofreeCodeCamp:mainfrom
Conversation
ojeytonwilliams
requested changes
Sep 19, 2025
Contributor
ojeytonwilliams
left a comment
ojeytonwilliams
left a comment
There was a problem hiding this comment.
Can you add a test script to the main package json? Otherwise this won't run in CI.
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
ojeytonwilliams
approved these changes
Sep 19, 2025
Member
huyenltnguyen
left a comment
huyenltnguyen
left a comment
There was a problem hiding this comment.
LGTM. I just have a question about a potential cleanup.
shared/vitest.config.mjs
Outdated
Member
There was a problem hiding this comment.
Could we remove this file?
I believe our file name pattern already follows the standard, and Vitest should be able to find the tests even without this config.
Contributor
There was a problem hiding this comment.
Good catch. Yes, this can go.
huyenltnguyen
added
the
scope: tools/scripts
huyenltnguyen
added
the
status: waiting update
majestic-owl448
added
the
MERGE CONFLICT!
github-actions
bot
removed
the
scope: tools/scripts
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
majestic-owl448
removed
the
MERGE CONFLICT!
ojeytonwilliams
added
status: waiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes #XXXXX
Now sure what to do about the transpiled tests? Should we exclude them from being generated?