refactor: blockType -> blockLabel

[ojeytonwilliams]

Checklist:

• I have read and followed the contribution guidelines.
• I have read and followed the how to open a pull request guide.
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitHub Codespaces.

The name blockType suggests that it should be used to differentiate between different kinds of blocks. This is quite vague and it already has a specific use: selecting which label to render. Calling it blockLabel makes it's role clear and should make further abuse less likely.

The one case where it was meaningful (when determining if a donation modal should appear) I used challengeType instead. challengeType is already used to differentiate between different kinds of challenges, so this is a least consistent with how it is already used. One idea we've discussed is splitting challengeType into more focused, more descriptive elements. I opted not to do that here to keep the change as simple as possible.

@freeCodeCamp/mobile I've changed the external curriculum. What do we need to change to handle that?

[huyenltnguyen]

For mobile, I think the easiest change would be:

• Update the curriculum model to handle pull both blockType and blockLabel from the curriculum data, so it's compatible with both "APIs"
  • https://github.com/freeCodeCamp/mobile/blob/981ace913f6d6174d4b71b9645bce31ca435612b/mobile-app/lib/models/learn/curriculum_model.dart#L208
• Release a new version with the change
• Merge this PR and deploy to prod whenever we're ready
• Only when blockLabel is available in prod, remove blockType from mobile

---

This is technically a breaking change, so do we want to... um... bump the external data version?

[huyenltnguyen]

Well actually, I wonder if we should keep blockType for mobile for now. In the external curricula scripts, we'll just pass blockLabel as blockType instead of renaming the field.

We'll need to bump the script version at some point, once FSD is replaced with the checkpoint certs and the English super blocks are converted to the chapter structure.

[ojeytonwilliams]

Both strategies seem fine to me, so I'd go with whichever seems like less hassle. Presumably rolling this change into the v3 you had planned?

I'll leave this blocked until we've got a clear path forward.

[huyenltnguyen]

Yeah, I'd vote to keep blockType in the external curricula data and defer this change to v3, so we don't need to change the mobile code yet.

[ojeytonwilliams]

I think this should work. It's compliant with the schema, at least.

[huyenltnguyen]

We've got a type check error apparently.